iOS 17 state restoration crash fix

[michalrentka]

The app crashed on iOS 17 during state restoration due to changes in #762. It crashed because

zotero-ios/Zotero/Scenes/Main/Views/MainViewController.swift

Line 96 in 27853fa

let tagFilterController = (self.viewControllers.first as? MasterContainerViewController)?.bottomController as? TagFilterViewController

was called before

zotero-ios/Zotero/Scenes/Master/MasterContainerViewController.swift

Line 104 in 27853fa

setupView()

was called and so the bottomController tried to add itself into bottomContainer, which didn't exist yet.

I fixed it by creating bottomController and not adding it as subview immediately, but I moved adding it as subview to viewDidLoad function together with other UI components.

I also noticed something I didn't notice during code review of #762 and that is that the distinction between MasterCoordinator and MasterTopCoordinator was not needed anymore, because the MasterContainerViewController took that role and connects "top" and "bottom" controllers together. The MasterCoordinator was almost empty anyway at this point, so I refactored a little and removed it.

Last fix is in

zotero-ios/Zotero/Scenes/Master/MasterContainerViewController.swift

Line 320 in 27853fa

showBottomSheet(!splitViewController.isCollapsed)

. Currently on state restoration, when you closed the PDF, the bottom tag picker would just pop up without animation, because it appered in viewDidAppear which is called too late. I moved it to viewIsAppearing which seems to have better effect.

[mvasilak]

viewIsAppearing works great and it's great that it is backwards compatible. One small note, it is called every time the view appears, and although in this case the actions would be noops after the first call, in some cases we may still need to guard with a Bool property, to truly run specific appearance logic only once.

[mvasilak]

In MasterContainerViewController since the setup of the bottom container happens only for iPad form, which is the best optimization, now in iPhone form bottomYConstraint & bottomContainerBottomConstraint may be nil, so they should become optional as well.

[michalrentka]

In MasterContainerViewController since the setup of the bottom container happens only for iPad form, which is the best optimization, now in iPhone form bottomYConstraint & bottomContainerBottomConstraint may be nil, so they should become optional as well.

Fixed in 6878aab, also there was another issue with keyboard apperance. When tag filter was in custom position and keyboard appeared, it just covered the filter if it was just too low. Fixed in 88f888f