Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old style of search bar, replace with iOS default style #765

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

michalrentka
Copy link
Contributor

@michalrentka michalrentka commented Sep 12, 2023

Fixes #764

@michalrentka
Copy link
Contributor Author

@dstillman can we move to current iOS defaul style of search bar? The current implementation is a bit hacky and had some issues, which seem to have been fixed by OS over time (or at least I didn't see any reports for some time). Anyway the current default is very similar and also works a bit smoother.

IMG_0551
IMG_0550

@michalrentka
Copy link
Contributor Author

@dstillman do these icons in order look better or do we maybe want to try compressing search bar into search icon in portrait?

IMG_58BAE0DEE75D-1

@dstillman
Copy link
Member

dstillman commented Sep 27, 2023

That's better. If we can, is there any reason not to collapse to search icon in all modes? I guess bigger tap target, clearer differentiation between the two search icons with the placeholder text, Files doesn't do it, and just sort of weird to have two identical icons if we can help it…

@michalrentka
Copy link
Contributor Author

That's better. If we can, is there any reason not to collapse to search icon in all modes? I guess bigger tap target, clearer differentiation between the two search icons with the placeholder text, Files doesn't do it, and just sort of weird to have two identical icons if we can help it…

We definitely don't have to collapse, it's optional (and possibly a bit more work, since it's not default behavior). I just mentioned it as a space saving method. Most apps with the search bar visible probably just keep it visible at all times.

@dstillman
Copy link
Member

Yeah, I just meant it seems a little silly to display the search box all the time, but not having two identical icons may be reason enough to keep it. So I guess until we need the room, we can leave it.

@michalrentka michalrentka merged commit 1fd0599 into zotero:master Sep 28, 2023
1 check failed
@michalrentka michalrentka deleted the searchfix branch September 28, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Update items search bar setup
3 participants