Fixed reentrancy issue in pdf reader

[michalrentka]

There was a RxSwift reentrancy issue in AnnotationsViewController.loadAttributedComment(for:) function. It was caused by calling self.viewModel.process(action: .parseAndCacheComment(key: annotation.key, comment: comment)) during ongoing update which then pushed another update.

[mvasilak]

@michalrentka this Reentrancy fix causes a regression, where annotation comments don't appear in the side bar.

The reason is that the returned value here doesn't use the updated state:

zotero-ios/Zotero/Scenes/Detail/PDF/Views/AnnotationsViewController.swift

Line 337 in 48e227d

return self.viewModel.state.comments[annotation.key]

I suggest we re-introduce the reentrancy for the upcoming release, so that the regression is reversed, and we open an issue to properly tackle the reentrancy afterwards.

[michalrentka]

@michalrentka this Reentrancy fix causes a regression, where annotation comments don't appear in the side bar.

The reason is that the returned value here doesn't use the updated state:

zotero-ios/Zotero/Scenes/Detail/PDF/Views/AnnotationsViewController.swift

Line 337 in 48e227d

return self.viewModel.state.comments[annotation.key]

I suggest we re-introduce the reentrancy for the upcoming release, so that the regression is reversed, and we open an issue to properly tackle the reentrancy afterwards.

Thanks for pointing out the issue. I was able to fix it with a rather simple fix so we shouldn't need to do anything else - #763