Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle lookup item & attachment creation in IdentifierLookupController #707

Merged
merged 46 commits into from
Nov 22, 2023
Merged

Handle lookup item & attachment creation in IdentifierLookupController #707

merged 46 commits into from
Nov 22, 2023

Commits on Nov 21, 2023

  1. Handle lookup item & attachment creation in IdentifierLookupController

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    bda1998 View commit details
    Browse the repository at this point in the history

  2. Improve LookupCoordinator

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    42e1a06 View commit details
    Browse the repository at this point in the history

  3. Cleanup unused code

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    2d5bcd8 View commit details
    Browse the repository at this point in the history

  4. Improve code clarity

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    6b33e8b View commit details
    Browse the repository at this point in the history

  5. Improve code style

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    bce09bd View commit details
    Browse the repository at this point in the history

  6. Provide batch data for RemoteAttachmentDownloader

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    bb36db9 View commit details
    Browse the repository at this point in the history

  7. Fix bug when compiling with Xcode 14.2

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    8f30807 View commit details
    Browse the repository at this point in the history

  8. Improve items toolbar progress update

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    1452c4a View commit details
    Browse the repository at this point in the history

  9. Refactor IdentifierLookupController

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    fea20e8 View commit details
    Browse the repository at this point in the history

  10. Move LookupWebViewHandler web view provision to protocol

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    66e4f77 View commit details
    Browse the repository at this point in the history

  11. Cleanup unused lookup web views

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    13f7038 View commit details
    Browse the repository at this point in the history

  12. Refactor IdentifierLookupController.Update

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    4772bc5 View commit details
    Browse the repository at this point in the history

  13. Move lookup coordination to IdentifierLookupController 

    Allow lookup to continue when lookup window closes
    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    8d53fd9 View commit details
    Browse the repository at this point in the history

  14. Use separate LookupWebViewHandler per library and collection keys

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    839ccd7 View commit details
    Browse the repository at this point in the history

  15. Improve nested functions code style in IdentifierLookupController

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    526e08b View commit details
    Browse the repository at this point in the history

  16. Show saved & total of identifier lookup in items toolbar

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    062efe0 View commit details
    Browse the repository at this point in the history

  17. Cleanup IdentifierLookupController lookup data when proper 

    Cleanup IdentifierLookupController lookup data when all lookups are
finished, and the lookup data are not presented
    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    b6d869a View commit details
    Browse the repository at this point in the history

  18. Restore any background lookup items when looking up a new identifier

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    3aa7d30 View commit details
    Browse the repository at this point in the history

  19. Allow restoration of lookup window from items toolbar progress view

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    baa3907 View commit details
    Browse the repository at this point in the history

  20. Update LookupViewController bar buttons

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    2d1b719 View commit details
    Browse the repository at this point in the history

  21. Add Cancel All button to lookup window 

    Add Cancel All button to lookup window that cancels pending
items/attachments and trashes already stored items/attachments
Fix bug in RemoteAttachmentDownloader
    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    6468fcd View commit details
    Browse the repository at this point in the history

  22. Improve RemoteAttachmentDownloader code clarity

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    cb464f6 View commit details
    Browse the repository at this point in the history

  23. Improve RemoteAttachmentDownloader download creation

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    72732e4 View commit details
    Browse the repository at this point in the history

  24. Improve RemoteAttachmentDownloader code clarity

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    2c6f30e View commit details
    Browse the repository at this point in the history

  25. Improve LookupActionHandler code clarity

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    b959cf1 View commit details
    Browse the repository at this point in the history

  26. Remove unnecessary protocol from IdentifierLookupController

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    d064a1b View commit details
    Browse the repository at this point in the history

  27. Improve IdentifierLookupController observers setup

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    79357ce View commit details
    Browse the repository at this point in the history

  28. Improve IdentifierLookupController error logging

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    f2343ea View commit details
    Browse the repository at this point in the history

  29. Simplify IdentifierLookupWebViewProvider protocol

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    8ed47ce View commit details
    Browse the repository at this point in the history

  30. Improve IdentifierLookupController code

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    566b044 View commit details
    Browse the repository at this point in the history

  31. Improve IdentifierLookupController performance

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    1fa7d16 View commit details
    Browse the repository at this point in the history

  32. Improve IdentifierLookupController logging

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    8fdc0cf View commit details
    Browse the repository at this point in the history

  33. Improve IdentifierLookupController cleanupLookupIfNeeded

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    1a9260b View commit details
    Browse the repository at this point in the history

  34. Improve IdentifierLookupController cleanupLookupIfNeeded code clarity

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    10d3573 View commit details
    Browse the repository at this point in the history

  35. Improve IdentifierLookupController initialize

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    c05b3b8 View commit details
    Browse the repository at this point in the history

  36. Improve IdentifierLookupController property access 

    Make access to batch data & current lookup data synchronous
    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    0e11558 View commit details
    Browse the repository at this point in the history

  37. Improve ItemsToolbarController 

    Improve ItemsToolbarController progress view
update when switching collections
    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    27b0632 View commit details
    Browse the repository at this point in the history

  38. Improve IdentifierLookupController 

    Simplify observation of IdentifierLookupController by LookupActionHandler
    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    5bb2f9f View commit details
    Browse the repository at this point in the history

  39. Improve items toolbar UI

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    f07496c View commit details
    Browse the repository at this point in the history

  40. Fix ManualLookupViewController UI when in phone idiom

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    711897b View commit details
    Browse the repository at this point in the history

  41. Improve LookupViewController table view height update

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    f26a475 View commit details
    Browse the repository at this point in the history

  42. Fix bug in IdentifierLookupController

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    5b01df4 View commit details
    Browse the repository at this point in the history

  43. Add SPM dependency apple/swift-collections v1.0.4

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    12641b2 View commit details
    Browse the repository at this point in the history

  44. Improve IdentifierLookupController logic 

    Ignore adding identifiers that have ongoing lookup
Cleanup web views when all current lookups finish
Dismiss lookup controller after canceling all lookups
    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    8918c74 View commit details
    Browse the repository at this point in the history

  45. Improve LookupState errors

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    f9f9b62 View commit details
    Browse the repository at this point in the history

  46. Fix SwiftLint error

    @mvasilak
    mvasilak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    a79a6f0 View commit details
    Browse the repository at this point in the history