Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove force_ssl to restore a working Render deployment #86

Merged
merged 2 commits into from
Sep 8, 2024
Merged

fix: remove force_ssl to restore a working Render deployment #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7736071
Add sobelow config file that notes our intent to ignore the `Config.H…
zorn Sep 8, 2024
f084a1b
Comment out `force_ssl` for now.
zorn Sep 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/code-quality.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,5 +42,5 @@ jobs:
if: always()

- name: Check for security vulnerabilities in Phoenix project
run: mix sobelow
run: mix sobelow --config
if: always()
1 change: 1 addition & 0 deletions .sobelow-conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[verbose: true, private: false, skip: false, router: nil, exit: false, format: "txt", out: nil, threshold: :low, ignore: ["Config.HTTPS"], ignore_files: [], version: false]
10 changes: 6 additions & 4 deletions config/prod.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
import Config

config :flick, FlickWeb.Endpoint,
# https://hexdocs.pm/phoenix/using_ssl.html#hsts
# FIXME: Restore this in the future.
# https://github.com/zorn/flick/issues/85
# force_ssl: [hsts: true]

# Note we also include the path to a cache manifest
# containing the digested version of static files. This
# manifest is generated by the `mix assets.deploy` task,
# which you should run after static files are built and
# before starting your production server.
cache_static_manifest: "priv/static/cache_manifest.json",

# https://hexdocs.pm/phoenix/using_ssl.html#hsts
force_ssl: [hsts: true]
cache_static_manifest: "priv/static/cache_manifest.json"

# Configures Swoosh API Client
config :swoosh, api_client: Swoosh.ApiClient.Finch, finch_name: Flick.Finch
Expand Down