-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Specify FUTURE_PYTHON_VERSION as version range" #219
Conversation
I disagree. From all I can tell all that breaks is that tox and GHA cannot find the interpreter. Instead of reverting the change in this package it is easy to just switch the future python flag in the affected packages' |
I'll look at this again today. |
In python/pythoncapi-compat#79 I learned that It seems we can close this issue and replace the version specifier by |
I can try that out later today. |
zopefoundation/DocumentTemplate#73 shows that the version range you proposed also works. |
https://github.com/zopefoundation/DocumentTemplate/actions/runs/6545745015/job/17774852634 proves that a simple "3.13" doesn't consider prereleases, the range as proposed is still the better solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is a 3.13 prerelease now I put the range specification back in.
As there is now an alpha release, this PR is no longer necessary. |
Reverts #218
Until there is a Python 3.13 alpha version at GHA the changes break running
config-package.py
ifwith-future-python
istrue
. I think the merge was done too early.We can revert this revert when the 3.13 alpha finally appears.
Needed for zopefoundation/zope.index#45