Get rid of DeprecationWarnings during unit tests #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-maurer
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
I am fine with your changes.
However, @icemac reported also a cgi.FieldStorage related deprecation warning. For it, https://peps.python.org/pep-0594/#cgi says
FieldStorage/MiniFieldStorage has no direct replacement, but can typically be replaced by
using [multipart](https://pypi.org/project/multipart/) (for POST and PUT requests)
or urllib.parse.parse_qsl (for GET and HEAD requests)
|
Yes, I know about the other warnings. My goal was not to fix everything, but all those that can be fixed in the time that I have available for these tasks. |
icemac
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1091 - Fixes at least those parts that are triggered by Zope itself.