4248 ownercollab read permissions for project preferences #4299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to Issue: #4248 |
yuenmichelle1
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Awesome. Changes look good. 👍
Not blocking, but I would add a test to ensure other attributes are not being serialized into the response for read/update_settings.
(Eg. 'read_settings response does not serialize irrelevant attributes') Something along those lines.
Pinging @zwolf so he's aware of changes made. (@zwolf no added work for you here, unless you wanted to add anything).
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
|
|
||
| expect(first_response).to have_key 'settings' | ||
| expect(first_response).to_not have_key 'activity_count_by_workflow' | ||
| expect(first_response).to_not have_key 'email_communication' |
There was a problem hiding this comment.
RSpec/NotToNot: Prefer not_to over to_not.
| first_response = json_response['project_preferences'].first | ||
|
|
||
| expect(first_response).to have_key 'settings' | ||
| expect(first_response).to_not have_key 'activity_count_by_workflow' |
There was a problem hiding this comment.
RSpec/NotToNot: Prefer not_to over to_not.
Tooyosi
deleted the
4248-ownercollab-read-permissions-for-project-preferences
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change here.
Review checklist
apiary.apibfile?