Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: work-in-progress warning for unmodified text subjects #6600

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eatyourgreens
Copy link
Contributor

@eatyourgreens eatyourgreens commented Jan 8, 2025

The text-from-subject task warns about work-in-progress for every subject. This fixes that by initialising the annotation value without marking the annotation as in-progress.

Please request review from @zooniverse/frontend team or an individual member of that team.

Package

  • lib-classifier

Linked Issue and/or Talk Post

How to Review

You should be able to refresh a new subject (reload the page) without getting the popup warning that you have work-in-progress.

If you make a change to the initial text, that should trigger the popup when you refresh the page (desktop browsers only.)

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

  • Tests are passing locally and on Github
  • Documentation is up to date and changelog has been updated if appropriate
  • You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
  • FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)
  • FEM works in a mobile browser

General UX

Example Staging Project: i-fancy-cats

  • All pages of a FEM project load: Home Page, Classify Page, and About Pages
  • Can submit a classification
  • Can sign-in and sign-out
  • The component is accessible

Bug Fix

  • The PR creator has listed user actions to use when testing if bug is fixed
  • The bug is fixed
  • Unit tests are added or updated

@coveralls
Copy link

coveralls commented Jan 8, 2025

Coverage Status

coverage: 77.389% (+0.02%) from 77.367%
when pulling b0244ca on eatyourgreens:patch-2
into 87ddcb4 on zooniverse:master.

@eatyourgreens eatyourgreens force-pushed the patch-2 branch 2 times, most recently from 501fce6 to 1e7b48f Compare January 8, 2025 08:58
@eatyourgreens eatyourgreens changed the title fix: work-in-progress warning for new text subjects fix: work-in-progress warning for unmodified text subjects Jan 8, 2025
The text-from-subject task warns about work-in-progress for every subject. This fixes that by setting the annotation value without marking the annotation as in-progress.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants