-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove API include requests #678
Labels
enhancement
New feature or request
Milestone
Comments
Is this a good place to use the GraphQL endpoint for projects? |
front-end-monorepo/packages/app-project/src/helpers/fetchWorkflowsHelper/fetchWorkflowsHelper.js Lines 3 to 11 in c09f091
|
18 tasks
#2016 will remove included subject sets from project workflows. |
eatyourgreens
added a commit
that referenced
this issue
Mar 19, 2021
Adds a query which gets available subject numbers, for a given workflow, from the Cellect API. Removes included subject sets from the workflows API query (see #678.) Subject sets are fetched separately, by ID, from the Panoptes API. This increases the number of API requests required to build each page, but allows us to limit subject set requests to grouped workflows. Updates the API mocks, in data-fetching tests, to include grouped/non-grouped cases and to add the /subject_sets endpoint. Refactors data-fetching into `fetchWorkflowsHelper` and `fetchSubjectSets`. Wraps the data-fetching requests in try/catch, so that we can log API errors to Sentry. Co-authored-by: Shaun A. Noordin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Avoid using include requests in the rebuild for API performance and an issue with incorrect data zooniverse/panoptes#3107
I think the only code location using them at the moment is here
front-end-monorepo/packages/lib-panoptes-js/src/resources/projects/commonRequests.js
Line 22 in d03960b
The text was updated successfully, but these errors were encountered: