Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace stats with eras client #6974

Merged
merged 10 commits into from
Dec 6, 2023
Merged

Conversation

yuenmichelle1
Copy link
Contributor

@yuenmichelle1 yuenmichelle1 commented Dec 2, 2023

Staging branch URL: https://pr-6974.pfe-preview.zooniverse.org

Fixes # .

Describe your changes.

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you npm ci and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on GitHub Actions?

Optional

@yuenmichelle1
Copy link
Contributor Author

oh poops. it looks like there is a failing test on Notifications https://github.com/zooniverse/Panoptes-Front-End/actions/runs/7088891506/job/19292378250?pr=6974#step:5:60
i think that once this PR gets merged into master (and pulled down into this branch) should fix these errors on the failing test

@mcbouslog mcbouslog self-requested a review December 4, 2023 21:41
@mcbouslog mcbouslog self-assigned this Dec 4, 2023
@yuenmichelle1 yuenmichelle1 marked this pull request as ready for review December 4, 2023 21:45
@coveralls
Copy link

coveralls commented Dec 4, 2023

Coverage Status

coverage: 56.987% (-0.01%) from 56.999%
when pulling 5388709 on replace-stats-with-erasClient
into ddfc8a9 on master.

Copy link
Contributor

@mcbouslog mcbouslog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app/pages/project/stats/stats.jsx Outdated Show resolved Hide resolved
app/pages/project/stats/stats.jsx Outdated Show resolved Hide resolved
app/pages/project/stats/stats.jsx Outdated Show resolved Hide resolved
Copy link
Contributor

@mcbouslog mcbouslog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! 🎉

Tested last few commits across browsers on a few projects and organization (https://pr-6974.pfe-preview.zooniverse.org/organizations/md68135/notes-from-nature/stats).

:shipit:

@mcbouslog mcbouslog merged commit 181fc93 into master Dec 6, 2023
5 checks passed
@mcbouslog mcbouslog deleted the replace-stats-with-erasClient branch December 6, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants