-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace stats with eras client #6974
Conversation
app/pages/organization/stats/components/BarChart/BarChartContainer.jsx
Outdated
Show resolved
Hide resolved
oh poops. it looks like there is a failing test on Notifications https://github.com/zooniverse/Panoptes-Front-End/actions/runs/7088891506/job/19292378250?pr=6974#step:5:60 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor notes/changes, see comments below, but really great!
Tested locally with production projects and organizations:
app/pages/organization/stats/components/BarChart/BarChartContainer.jsx
Outdated
Show resolved
Hide resolved
app/pages/organization/stats/components/BarChart/BarChartContainer.jsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Mark Bouslog <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! 🎉
Tested last few commits across browsers on a few projects and organization (https://pr-6974.pfe-preview.zooniverse.org/organizations/md68135/notes-from-nature/stats).
Staging branch URL: https://pr-6974.pfe-preview.zooniverse.org
Fixes # .
Describe your changes.
Required Manual Testing
Review Checklist
npm ci
and app works as expected?Optional
ChangeListener
orPromiseRenderer
components with code that updates component state?