Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency rubocop to v1.69.2 #848

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 31, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
rubocop (source, changelog) '1.65.1' -> '1.69.2' age adoption passing confidence

Release Notes

rubocop/rubocop (rubocop)

v1.69.2

Compare Source

Bug fixes
  • #​13553: Fix an incorrect autocorrect for Style/MultipleComparison when a variable is compared multiple times after a method call. ([@​koic][])
  • #​13562: Fix Bundler/DuplicatedGem cop error in case of empty branch. ([@​viralpraxis][])
  • #​13573: Fix Lint/UnescapedBracketInRegexp cop failure with invalid multibyte escape. ([@​earlopain][])
  • #​13556: Fix false positives for Style/FileNull when using 'nul' string. ([@​koic][])
  • #​12995: Fix --disable-uncorrectable to not insert directives inside a string. ([@​dvandersluis][])
  • #​13320: Fix incorrect autocorrect when Layout/LineContinuationLeadingSpace and Style/StringLiterals autocorrects in the same pass. ([@​dvandersluis][])
  • #​13299: Fix Style/BlockDelimiters to always accept braces when an operator method argument is chained. ([@​dvandersluis][])
  • #​13565: Fix Style/RedundantLineContinuation false negatives when a redundant continuation follows a required continuation. ([@​dvandersluis][])
  • #​13551: Fix an incorrect autocorrect for Style/IfWithSemicolon when using multi value assignment in if with a semicolon is used. ([@​koic][])
  • #​13534: Fix Layout/LineLength cop failure in case of YARD-comment-like string. ([@​viralpraxis][])
  • #​13558: Fix Lint/NonAtomicFileOperation cop error in case of implicit receiver. ([@​viralpraxis][])
  • #​13564: Fix Metrics/ClassLength cop error in case of chained assignments. ([@​viralpraxis][])
  • #​13570: Fix Naming/RescuedExceptionsVariableName cop error when exception is assigned with writer method. ([@​viralpraxis][])
  • #​13559: Fix a false positive for Style/RedundantLineContinuation when a method definition is used as an argument for a method call. ([@​davidrunger][])
  • #​13574: Fix Style/ExactRegexpMatch cop error on invalid regular expression literal. ([@​viralpraxis][])
  • #​13554: Fix Style/FrozenStringLiteralComment false positive in case of non-downcased value literal. ([@​viralpraxis][])
  • #​13569: Fix Style/MethodCallWithoutArgsParentheses cop error in case of mass hash assignment. ([@​viralpraxis][])
  • #​13542: Fix Style/RedundantCondition cop failure in case of empty arguments. ([@​viralpraxis][])
  • #​13509: Update Layout/ExtraSpacing and Layout/SpaceAroundOperators to handle preceding operators inside strings. ([@​dvandersluis][])

v1.69.1

Compare Source

Bug fixes
  • #​13502: Fix an incorrect autocorrect for Style/DigChain when using safe navigation method chain with dig method. ([@​koic][])
  • #​13505: Fix an error for Style/ParallelAssignment when using the anonymous splat operator. ([@​earlopain][])
  • #​13184: Fix some false positives in Lint/UnreachableCode. ([@​isuckatcs][])
  • #​13494: Fix false positives for Style/HashExcept cop when using reject/!include?, reject/!in? or select/!exclude? combinations. ([@​lovro-bikic][])
  • #​13522: Fix Lint/UnescapedBracketInRegexp cop failure with invalid regular expression. ([@​viralpraxis][])
  • #​13523: Fix Style::AccessModifierDeclarations cop failure in case of if node without else. ([@​viralpraxis][])
  • #​13524: Fix Style/RedundantArgument cop failure while inspecting string literal with invalid encoding. ([@​viralpraxis][])
  • #​13528: Fix Style/RedundantParentheses cop failure in case of splatted case node without condition. ([@​viralpraxis][])
  • #​13521: Fix Style/RedundantSelf cop failure with kwnilarg argument node. ([@​viralpraxis][])
  • #​13526: Fix Style/StringConcatenation cop failure when there are mixed implicit and explicit concatenations. ([@​viralpraxis][])
  • #​13511: Fix false positive in Lint/UnescapedBracketInRegexp when using regexp_parser 2.9.2 and earlier. ([@​dvandersluis][])
  • #​13096: Update Style/BlockDelimiters to not change braces when they are required for syntax. ([@​dvandersluis][])
  • #​13512: Update Style/LambdaCall to be aware of safe navigation. ([@​dvandersluis][])

v1.69.0

Compare Source

New features
Bug fixes
  • #​13455: Fix a false positive for Layout/EmptyLineAfterGuardClause when using a guard clause outside oneliner block. ([@​koic][])
  • #​13412: Fix a false positive for Style/RedundantLineContinuation when there is a line continuation at the end of Ruby code followed by __END__ data. ([@​koic][])
  • #​13476: Allow to write generics type of RBS::Inline annotation after subclass definition in Style/CommentedKeyword. ([@​dak2][])
  • #​13441: Fix an incorrect autocorrect for Style/IfWithSemicolon when using return with value in if with a semicolon is used. ([@​koic][])
  • #​13448: Fix an incorrect autocorrect for Style/IfWithSemicolon when the then body contains an arithmetic operator method call with an argument. ([@​koic][])
  • #​13199: Make Style/RedundantCondition skip autocorrection when a branch has a comment. ([@​koic][])
  • #​13411: Fix Style/BitwisePredicate when having regular method. ([@​d4be4st][])
  • #​13432: Fix false positive for Lint/FloatComparison against nil. ([@​lovro-bikic][])
  • #​13461: Fix false positives for Lint/InterpolationCheck when using invalid syntax in interpolation. ([@​koic][])
  • #​13402: Fix a false positive for Lint/SafeNavigationConsistency when using unsafe navigation with both && and ||. ([@​koic][])
  • #​13434: Fix a false positive for Naming/MemoizedInstanceVariableName for assignment methods`. ([@​earlopain][])
  • #​13415: Fix false positives for Naming/MemoizedInstanceVariableName when using initialize_clone, initialize_copy, or initialize_dup. ([@​koic][])
  • #​13421: Fix false positives for Style/SafeNavigation when using a method chain that exceeds the MaxChainLength value and includes safe navigation operator. ([@​koic][])
  • #​13433: Fix autocorrection for Style/AccessModifierDeclarations for multiple inline symbols. ([@​dvandersluis][])
  • #​13430: Fix EmptyLinesAroundMethodBody for methods with arguments spanning multiple lines. ([@​aduth][])
  • #​13438: Fix incorrect correction in Lint/Void if an operator is called in a void context using a dot. ([@​dvandersluis][])
  • #​13419: Fix Lint/DeprecatedOpenSSLConstant false positive when the argument is a safe navigation method call. ([@​dvandersluis][])
  • #​13404: Fix Style/AccessModifierDeclarations to register (as positive or negative, depending on AllowModifiersOnSymbols value) access modifiers with multiple symbols. ([@​dvandersluis][])
  • #​13436: Fix incorrect offense and autocorrect for Lint/RedundantSplatExpansion when percent literal array is used in a safe navigation method call. ([@​lovro-bikic][])
  • #​13442: Fix an incorrect autocorrect for Style/NestedTernaryOperator when ternary operators are nested and the inner condition is parenthesized. ([@​koic][])
  • #​13444: Fix an incorrect autocorrect for Style/OneLineConditional when the else branch of a ternary operator has multiple expressions. ([@​koic][])
  • #​13483: Fix an incorrect autocorrect for Style/RedundantRegexpArgument when using escaped double quote character. ([@​koic][])
  • #​13497: Fix infinite loop error for Style/IfWithSemicolon when using nested if/;/end in if body. ([@​koic][])
  • #​13477: Update Layout/LeadingCommentSpace to accept multiline shebangs at the top of the file. ([@​dvandersluis][])
  • #​13453: Update Style/AccessModifierDeclarations to handle attr_* methods with multiple parameters. ([@​dvandersluis][])
  • #​12597: Update Style/SingleLineDoEndBlock to not register an offense if it will introduce a conflicting Layout/RedundantLineBreak offense. ([@​dvandersluis][])
Changes

v1.68.0

Compare Source

New features
Bug fixes
  • #​13401: Fix a false negative for Style/RedundantLineContinuation when there is a line continuation at the EOF. ([@​koic][])
  • #​13368: Fix an incorrect autocorrect for Naming/BlockForwarding with Style/ExplicitBlockArgument. ([@​koic][])
  • #​13391: Fix deserialization of unknown encoding offenses. ([@​earlopain][])
  • #​13348: Ensure Style/BlockDelimiters autocorrection does not move other code between the block and comment. ([@​dvandersluis][])
  • #​13382: Fix an error during error handling for custom ruby extractors when the extractor is a class. ([@​earlopain][])
  • #​13309: Fix a false negative for Lint/UselessAssignment cop when there is a useless assignment followed by a block. ([@​pCosta99][])
  • #​13255: Fix false negatives for Style/MapIntoArray when using non-splatted arguments. ([@​vlad-pisanov][])
  • #​13356: Fix a false positive for Layout/SpaceBeforeBrackets when there is a dot before []=. ([@​earlopain][])
  • #​13365: Fix false positives for Lint/SafeNavigationConsistency when using safe navigation on the LHS with operator method on the RHS of &&. ([@​koic][])
  • #​13390: Fix false positives for Style/GuardClause when using a local variable assigned in a conditional expression in a branch. ([@​koic][])
  • #​13337: Fix false positives for Style/RedundantLineContinuation when required line continuations for && is used with an assignment after a line break. ([@​koic][])
  • #​13387: Fix false positives in Style/RedundantParentheses when parentheses are used around method chain with do...end block in keyword argument. ([@​koic][])
  • #​13341: Fix false positives for Lint/SafeNavigationChain when a safe navigation operator is used with a method call as the RHS operand of && for the same receiver. ([@​koic][])
  • #​13324: Fix --disable-uncorrectable to not insert a comment inside a string continuation. ([@​dvandersluis][])
  • #​13364: Fix incorrect autocorrect with Lint/UselessAssignment a multiple assignment or for contains an inner assignment. ([@​dvandersluis][])
  • #​13353: Fix an incorrect autocorrect for Style/BlockDelimiters when EnforcedStyle: semantic is set and used with Layout/SpaceInsideBlockBraces. ([@​koic][])
  • #​13361: Fix false positives for Style/RedundantInterpolationUnfreeze and Style/RedundantFreeze when strings contain interpolated global, instance, and class variables. ([@​vlad-pisanov][])
  • #​13343: Prevent Layout/LineLength from breaking up a method with arguments chained onto a heredoc delimiter. ([@​dvandersluis][])
  • #​13374: Return exit code 0 with --display-only-correctable and --display-only-safe-correctable when no offenses are displayed. ([@​dvandersluis][])
  • #​13193: Fix false positive in Style/MultipleComparison when ComparisonsThreshold exceeds 2. ([@​fatkodima][],[@​vlad-pisanov][])
  • #​13325: Fix an incorrect autocorrect for Lint/NonAtomicFileOperation when using a postfix unless for file existence checks before creating a file, in cases with Dir.mkdir. ([@​kotaro0522][])
  • #​13397: Update PercentLiteralCorrector to be able to write pairs of delimiters without excessive escaping. ([@​dvandersluis][])
  • #​13336: Update Style/SafeNavigation to not autocorrect if the RHS of an and node is an or node. ([@​dvandersluis][])
  • #​13378: When removing parens in Style/TernaryParentheses with a send node condition, ensure its arguments are parenthesized. ([@​dvandersluis][])
Changes
  • #​13347: When running rubocop -V, show the analysis Ruby version of the current directory. ([@​earlopain][])

v1.67.0

Compare Source

New features
  • #​13259: Add new Lint/DuplicateSetElement cop. ([@​koic][])
  • #​13223: Add AllowRBSInlineAnnotation config option to Layout/LeadingCommentSpace to support RBS::Inline style annotation comments. ([@​tk0miya][])
  • #​13310: Display analysis Ruby version in rubocop -V. ([@​koic][])
Bug fixes
  • #​13314: Fix a false negative for Style/Semicolon when using a semicolon between a closing parenthesis after a line break and a consequent expression. ([@​koic][])
  • #​13217: Fix a false positive in Lint/ParenthesesAsGroupedExpression with compound ranges. ([@​gsamokovarov][])
  • #​13268: Fix a false positive for Style/BlockDelimiters when a single line do-end block with an inline rescue with a semicolon before rescue. ([@​koic][])
  • #​13298: Fix an error for Layout/AccessModifierIndentation when the access modifier is on the same line as the class definition. ([@​koic][])
  • #​13198: Fix an error for Style/OneLineConditional when using nested if/then/else/end. ([@​koic][])
  • #​13316: Fix an incorrect autocorrect for Lint/ImplicitStringConcatenation with Lint/TripleQuotes when string literals with triple quotes are used. ([@​koic][])
  • #​13220: Fix an incorrect autocorrect for Style/ArgumentsForwarding when using only forwarded arguments in brackets. ([@​koic][])
  • #​13202: Fix an incorrect autocorrect for Style/CombinableLoops when looping over the same data with different block variable names. ([@​koic][])
  • #​13291: Fix an incorrect autocorrect for Style/RescueModifier when using modifier rescue for method call with heredoc argument. ([@​koic][])
  • #​13226: Fix --auto-gen-config when passing an absolute config path. ([@​earlopain][])
  • #​13225: Avoid syntax error when correcting Style/OperatorMethodCall with / operations followed by a parenthesized argument. ([@​dvandersluis][])
  • #​13235: Fix an error for Style/IfUnlessModifier when multiline if that fits on one line and using implicit method call with hash value omission syntax. ([@​koic][])
  • #​13219: Fix a false positive for Style/ArgumentsForwarding with Ruby 3.0 and optional position arguments. ([@​earlopain][])
  • #​13271: Fix a false positive for Lint/AmbiguousRange when using rational literals. ([@​koic][])
  • #​13260: Fix a false positive for Lint/RedundantSafeNavigation with namespaced constants. ([@​earlopain][])
  • #​13224: Fix false positives for Style/OperatorMethodCall with named forwarding. ([@​earlopain][])
  • #​13213: Fix false positives for Style/AccessModifierDeclarations when AllowModifiersOnAttrs: true and using splat with a percent symbol array, or with a constant. ([@​koic][])
  • #​13145: Fix false positives for Style/RedundantLineContinuation when line continuations with comparison operator and the LHS is wrapped in parentheses. ([@​koic][])
  • #​12875: Fix false positive for Style/ArgumentsForwarding when argument is used inside a block. ([@​dvandersluis][])
  • #​13239: Fix false positive for Style/CollectionCompact when using delete_if. ([@​masato-bkn][])
  • #​13210: Fix omit_parentheses style for pattern match with value omission in single-line branch. ([@​gsamokovarov][])
  • #​13149: Handle crashes in custom Ruby extractors more gracefully. ([@​earlopain][])
  • #​13319: Handle literal forward slashes inside a regexp in Lint/LiteralInInterpolation. ([@​dvandersluis][])
  • #​13208: Fix an incorrect autocorrect for Style/IfWithSemicolon when single-line if/;/end when the then body contains a method call with [] or []=. ([@​koic][])
  • #​13318: Prevent modifying blocks with Style/HashEachMethods if the hash is modified within the block. ([@​dvandersluis][])
  • #​13293: Fix TargetRubyVersion from a gemspec when the gemspec is not named like the folder it is located in. ([@​earlopain][])
  • #​13211: Fix wrong autocorrect for Style/GuardClause when using heredoc without else branch. ([@​earlopain][])
  • #​13215: Fix wrong autocorrect for Lint/BigDecimalNew when using ::BigDecimal.new. ([@​earlopain][])
  • #​13215: Fix wrong autocorrect for Style/MethodCallWithArgsParentheses with EnforcedStyle: omit_parentheses and whitespace. ([@​earlopain][])
  • #​13302: Fix incompatible autocorrect between Style/RedundantBegin and Style/BlockDelimiters with EnforcedStyle: braces_for_chaining. ([@​earlopain][])
Changes
  • #​13221: Do not group accessors having RBS::Inline annotation comments in Style/AccessorGrouping. ([@​tk0miya][])
  • #​13286: Add AllowedMethods configuration to Layout/FirstMethodArgumentLineBreak. ([@​dvandersluis][])
  • #​13110: Add support in Style/ArgumentsForwarding for detecting forwarding of all anonymous arguments. ([@​dvandersluis][])
  • #​13222: Allow to write RBS::Inline annotation comments after method definition in Style/CommentedKeyword. ([@​tk0miya][])
  • #​13253: Emit a deprecation when custom cops inherit from RuboCop::Cop::Cop. ([@​earlopain][])
  • #​13300: Set EnforcedShorthandSyntax: either by default for Style/HashSyntax. ([@​koic][])
  • #​13254: Enhance the autocorrect for Naming/InclusiveLanguage when a sole suggestion is set. ([@​koic][])
  • #​13232: Make server mode aware of auto-restart for local config update. ([@​koic][])
  • #​13270: Make Style/SelectByRegexp aware of filter in Ruby version 2.6 or above. ([@​masato-bkn][])
  • #​9816: Refine Lint/SafeNavigationConsistency cop to check that the safe navigation operator is applied consistently and without excess or deficiency. ([@​koic][])
  • #​13256: Report and correct more Style/SafeNavigation offenses. ([@​dvandersluis][])
  • #​13245: Support filter/filter! in Style/CollectionCompact. ([@​masato-bkn][])
  • #​13281: Support Ruby 3.4 for Lint/UriRegexp to avoid obsolete API. ([@​koic][])
  • #​13229: Update Style/MapIntoArray to be able to handle arrays created using [].tap. ([@​dvandersluis][])
  • #​13305: Update Style/ReturnNilInPredicateMethodDefinition to detect implicit nil returns inside if. ([@​dvandersluis][])
  • #​13327: Make server mode aware of auto-restart for .rubocop_todo.yml update. ([@​koic][])

v1.66.1

Compare Source

Bug fixes
  • #​13191: Fix an error for Style/IfWithSemicolon when using nested single-line if/;/end in block of if/else branches. ([@​koic][])
  • #​13178: Fix false positive for Style/EmptyLiteral with Hash.new([]). ([@​earlopain][])
  • #​13176: Fix crash in Style/EmptyElse when AllowComments: true and the else clause is missing. ([@​vlad-pisanov][])
  • #​13185: Fix false negatives in Style/MapIntoArray autocorrection when using ensure, def, defs and for. ([@​vlad-pisanov][])

v1.66.0

Compare Source

New features
  • #​13077: Add new global StringLiteralsFrozenByDefault option for correct analysis with RUBYOPT=--enable=frozen-string-literal. ([@​earlopain][])
  • #​13080: Add new DocumentationExtension global option to serve documentation with extensions different than .html. ([@​earlopain][])
  • #​13074: Add new Lint/UselessNumericOperation cop to check for inconsequential numeric operations. ([@​zopolis4][])
  • #​13061: Add new Style/RedundantInterpolationUnfreeze cop to check for dup and @+ on interpolated strings in Ruby >= 3.0. ([@​earlopain][])
Bug fixes
  • #​13093: Fix an error for Lint/ImplicitStringConcatenation when implicitly concatenating a string literal with a line break and string interpolation. ([@​koic][])
  • #​13098: Fix an error for Style/IdenticalConditionalBranches when handling empty case branches. ([@​koic][])
  • #​13113: Fix an error for Style/IfWithSemicolon when a nested if with a semicolon is used. ([@​koic][])
  • #​13097: Fix an error for Style/InPatternThen when using alternative pattern matching deeply. ([@​koic][])
  • #​13159: Fix an error for Style/OneLineConditional when using if/then/else/end with multiple expressions in the then body. ([@​koic][])
  • #​13092: Fix an incorrect autocorrect for Layout/EmptyLineBetweenDefs when two method definitions are on the same line separated by a semicolon. ([@​koic][])
  • #​13116: Fix an incorrect autocorrect for Style/IfWithSemicolon when a single-line if/;/end has an argument in the then body expression. ([@​koic][])
  • #​13161: Fix incorrect autocorrect for Style/IfWithSemicolon when using multiple expressions in the else body. ([@​koic][])
  • #​13132: Fix incorrect autocorrect for Style/TrailingBodyOnMethodDefinition when an expression precedes a method definition on the same line with a semicolon. ([@​koic][])
  • #​13164: Fix incorrect autocorrect behavior for Layout/BlockAlignment when EnforcedStyleAlignWith: either (default). ([@​koic][])
  • #​13087: Fix an incorrect autocorrect for Style/MultipleComparison when expression with more comparisons precedes an expression with less comparisons. ([@​fatkodima][])
  • #​13172: Fix an error for Layout/EmptyLinesAroundExceptionHandlingKeywords when ensure or else and end are on the same line. ([@​koic][])
  • #​13107: Fix an error for Lint/ImplicitStringConcatenation when there are multiple adjacent string interpolation literals on the same line. ([@​koic][])
  • #​13111: Fix an error for Style/GuardClause when if clause is empty and correction would not fit on single line because of Layout/LineLength. ([@​earlopain][])
  • #​13137: Fix an error for Style/ParallelAssignment when using __FILE__. ([@​earlopain][])
  • #​13143: Fix an error during TargetRubyVersion detection if the gemspec is not valid syntax. ([@​earlopain][])
  • #​13131: Fix false negatives for Lint/Void when using ensure, defs and numblock. ([@​vlad-pisanov][])
  • #​13174: Fix false negatives for Style/MapIntoArray when initializing the destination using Array[], Array([]), or Array.new([]). ([@​vlad-pisanov][])
  • #​13173: Fix false negatives for Style/EmptyLiteral when using Array[], Hash[], Array.new([]) and Hash.new([]). ([@​vlad-pisanov][])
  • #​13126: Fix a false positive for Style/Alias when using multiple alias in def. ([@​koic][])
  • #​13085: Fix a false positive for Style/EmptyElse when a comment-only else is used after elsif and AllowComments: true is set. ([@​koic][])
  • #​13118: Fix a false positive for Style/MapIntoArray when splatting. ([@​earlopain][])
  • #​13105: Fix false positives for Style/ArgumentsForwarding when forwarding kwargs/block arg with non-matching additional args. ([@​koic][])
  • #​13139: Fix false positives for Style/RedundantCondition when using modifier if or unless. ([@​koic][])
  • #​13134: Fix false negative for Lint/Void when using using frozen literals. ([@​vlad-pisanov][])
  • #​13148: Fix incorrect autocorrect for Lint/EmptyConditionalBody when missing elsif body with end on the same line. ([@​koic][])
  • #​13109: Fix an error for the Lockfile parser when it contains incompatible BUNDLED WITH versions. ([@​earlopain][])
  • #​13112: Fix detection of TargetRubyVersion through the gemfile if the gemfile ruby version is below 2.7. ([@​earlopain][])
  • #​13155: Fixes an error when the server cache directory has too long path, causing rubocop to fail even with caching disabled. ([@​protocol7][])
Changes
  • #​13050: Allow get_!, set_!, get_?, set_?, get_=, and set_= in Naming/AccessorMethodName. ([@​koic][])
  • #​13103: Make Lint/UselessAssignment autocorrection safe. ([@​koic][])
  • #​13099: Make Style/RedundantRegexpArgument respect the EnforcedStyle of Style/StringLiterals. ([@​koic][])
  • #​13165: Remove dependency on the rexml gem. ([@​bquorning][])
  • #​13090: Require RuboCop AST 1.32.0+ to use RuboCop::AST::RationalNode. ([@​koic][])

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@yegor256
Copy link
Collaborator

@rultor please, try to merge, since 9 checks have passed

@rultor
Copy link
Collaborator

rultor commented Aug 31, 2024

@rultor please, try to merge, since 9 checks have passed

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Aug 31, 2024

@rultor please, try to merge, since 9 checks have passed

@renovate[bot] @yegor256 Oops, I failed. You can see the full log here (spent 32min)

TestRemove
  test_removes_one_wallet                                        \u001b[32m PASS\u001b[0m (0.31s)
  test_removes_no_wallets                                        \u001b[32m PASS\u001b[0m (0.08s)
  test_removes_wallets                                           \u001b[32m PASS\u001b[0m (0.17s)
  test_removes_absent_wallets                                    \u001b[32m PASS\u001b[0m (0.07s)

TestPrefixes
  test_creates_and_validates                                     \u001b[32m PASS\u001b[0m (138.80s)

TestFetch
  test_fetches_multiple_wallets                                  \u001b[32m PASS\u001b[0m (0.88s)
  test_fails_when_only_one_node                                  \u001b[32m PASS\u001b[0m (0.24s)
  test_fetches_wallet                                            \u001b[32m PASS\u001b[0m (0.48s)
  test_fails_when_only_edge_nodes                                \u001b[32m PASS\u001b[0m (0.24s)

TestPull
  test_pull_wallet                                               \u001b[32m PASS\u001b[0m (0.88s)
  test_fails_when_only_edge_nodes                                \u001b[32m PASS\u001b[0m (0.32s)

TestCreate
  test_creates_wallet                                            \u001b[32m PASS\u001b[0m (0.23s)

TestRemotes
  test_adds_from_many_threads                                    \u001b[32m PASS\u001b[0m (9.37s)
  test_resets_remotes                                            \u001b[32m PASS\u001b[0m (0.24s)
  test_modifies_from_many_threads                                \u001b[32m PASS\u001b[0m (0.24s)
  test_finds_masters                                             \u001b[32m PASS\u001b[0m (0.00s)
  test_manifests_correct_network_name                            \u001b[32m PASS\u001b[0m (0.08s)
  test_iterates_and_fails                                        \u001b[32m PASS\u001b[0m (3.59s)
  test_iterates_all_failures                                     \u001b[32m PASS\u001b[0m (0.25s)
  test_reads_mtime_from_empty_file                               \u001b[32m PASS\u001b[0m (0.00s)
  test_read_mtime_from_file                                      \u001b[32m PASS\u001b[0m (0.07s)
  test_reads_broken_file                                         \u001b[32m PASS\u001b[0m (0.01s)
  test_unerror_remote                                            \u001b[32m PASS\u001b[0m (0.15s)
  test_mtime                                                     \u001b[32m PASS\u001b[0m (0.00s)
  test_adds_remotes                                              \u001b[32m PASS\u001b[0m (0.00s)
  test_iterates_them_all_even_with_delays                        \u001b[32m PASS\u001b[0m (1.68s)
  test_modifies_score                                            \u001b[32m PASS\u001b[0m (0.07s)
  test_closes_threads_carefully                                  \u001b[32m PASS\u001b[0m (1.60s)
  test_quickly_ads_and_reads                                     \u001b[31mERROR\u001b[0m (36.00s)
Minitest::UnexpectedError:         RuntimeError: Can't stop the pool
            /usr/local/rvm/gems/ruby-3.2.2/gems/threads-0.4.0/lib/threads.rb:70:in `assert'
            test/test_remotes.rb:253:in `block in test_quickly_ads_and_reads'
            /usr/local/rvm/rubies/ruby-3.2.2/lib/ruby/3.2.0/tmpdir.rb:94:in `mktmpdir'
            test/test_remotes.rb:248:in `test_quickly_ads_and_reads'


Interrupted. Exiting...

Finished in 247.83895s
103 tests, 3396 assertions, \u001b[31m0 failures, 1 errors, \u001b[0m\u001b[33m5 skips\u001b[0m
rake aborted!
Command failed with status (1): [ruby -I"lib:lib:test" /usr/local/rvm/gems/ruby-3.2.2/gems/rake-13.2.1/lib/rake/rake_test_loader.rb "test/commands/routines/test_audit.rb" "test/commands/routines/test_gc.rb" "test/commands/routines/test_reconcile.rb" "test/commands/routines/test_reconnect.rb" "test/commands/routines/test_retire.rb" "test/commands/test_alias.rb" "test/commands/test_calculate.rb" "test/commands/test_clean.rb" "test/commands/test_create.rb" "test/commands/test_diff.rb" "test/commands/test_fetch.rb" "test/commands/test_invoice.rb" "test/commands/test_list.rb" "test/commands/test_merge.rb" "test/commands/test_node.rb" "test/commands/test_pay.rb" "test/commands/test_propagate.rb" "test/commands/test_pull.rb" "test/commands/test_push.rb" "test/commands/test_remote.rb" "test/commands/test_remove.rb" "test/commands/test_show.rb" "test/commands/test_taxes.rb" "test/node/test_async_entrance.rb" "test/node/test_entrance.rb" "test/node/test_farm.rb" "test/node/test_farmers.rb" "test/node/test_front.rb" "test/node/test_nodup_entrance.rb" "test/node/test_nospam_entrance.rb" "test/node/test_safe_entrance.rb" "test/node/test_spread_entrance.rb" "test/node/test_sync_entrance.rb" "test/node/test_trace.rb" "test/test__helper.rb" "test/test_age.rb" "test/test_amount.rb" "test/test_cached_wallets.rb" "test/test_copies.rb" "test/test_dir_items.rb" "test/test_gem.rb" "test/test_hands.rb" "test/test_hexnum.rb" "test/test_http.rb" "test/test_hungry_wallets.rb" "test/test_id.rb" "test/test_json_page.rb" "test/test_key.rb" "test/test_log.rb" "test/test_metronome.rb" "test/test_patch.rb" "test/test_prefixes.rb" "test/test_remotes.rb" "test/test_signature.rb" "test/test_size.rb" "test/test_sync_wallets.rb" "test/test_tax.rb" "test/test_thread_pool.rb" "test/test_tree_wallets.rb" "test/test_txn.rb" "test/test_upgrades.rb" "test/test_verbose_thread.rb" "test/test_version.rb" "test/test_wallet.rb" "test/test_wallets.rb" "test/test_zold.rb" "test/upgrades/test_delete_banned_wallets.rb" "test/upgrades/test_protocol_up.rb" ]
/usr/local/rvm/gems/ruby-3.2.2/gems/rake-13.2.1/exe/rake:27:in `<top (required)>'
/usr/local/rvm/gems/ruby-3.2.2/bin/ruby_executable_hooks:22:in `eval'
/usr/local/rvm/gems/ruby-3.2.2/bin/ruby_executable_hooks:22:in `<main>'
Tasks: TOP => default => test
(See full trace by running task with --trace)
container 7974eb35dda7c9da65f045fff700bde996fb0d13928b11d3ab632e31778a3f0b is dead
Sat Aug 31 17:19:58 UTC 2024

@renovate renovate bot force-pushed the renovate/rubocop-1.x branch from 611ae8d to 6d02696 Compare September 4, 2024 11:07
@renovate renovate bot changed the title Update dependency rubocop to v1.66.0 Update dependency rubocop to v1.66.1 Sep 4, 2024
@renovate renovate bot force-pushed the renovate/rubocop-1.x branch from 6d02696 to 78e48bb Compare October 15, 2024 14:35
@renovate renovate bot changed the title Update dependency rubocop to v1.66.1 Update dependency rubocop to v1.67.0 Oct 15, 2024
@renovate renovate bot changed the title Update dependency rubocop to v1.67.0 Update dependency rubocop to v1.68.0 Oct 31, 2024
@renovate renovate bot force-pushed the renovate/rubocop-1.x branch from 78e48bb to d97ca82 Compare October 31, 2024 10:04
@renovate renovate bot force-pushed the renovate/rubocop-1.x branch from d97ca82 to 41d4320 Compare November 26, 2024 16:58
@renovate renovate bot changed the title Update dependency rubocop to v1.68.0 Update dependency rubocop to v1.69.0 Nov 26, 2024
@renovate renovate bot force-pushed the renovate/rubocop-1.x branch from 41d4320 to 2afa9c3 Compare December 3, 2024 11:25
@renovate renovate bot changed the title Update dependency rubocop to v1.69.0 Update dependency rubocop to v1.69.1 Dec 3, 2024
@renovate renovate bot force-pushed the renovate/rubocop-1.x branch from 2afa9c3 to 916db38 Compare December 12, 2024 18:05
@renovate renovate bot changed the title Update dependency rubocop to v1.69.1 Update dependency rubocop to v1.69.2 Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants