Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#651 Stream HTTP PUT request's body #766

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

v-kolesnikov
Copy link

Issue #651

@0crat 0crat added the scope label Jun 9, 2019
@0crat
Copy link
Collaborator

0crat commented Jun 9, 2019

Job #766 is now in scope, role is REV

@codecov-io
Copy link

codecov-io commented Jun 10, 2019

Codecov Report

Merging #766 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #766      +/-   ##
==========================================
- Coverage   33.83%   33.79%   -0.05%     
==========================================
  Files          76       76              
  Lines        3821     3826       +5     
==========================================
  Hits         1293     1293              
- Misses       2528     2533       +5
Impacted Files Coverage Δ
lib/zold/http.rb 47.76% <0%> (-3.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6171603...b6aea58. Read the comment docs.

@v-kolesnikov v-kolesnikov changed the title #652 Stream HTTP PUT request's body #651 Stream HTTP PUT request's body Jun 12, 2019
@v-kolesnikov
Copy link
Author

I'm not sure it needs to be unit-tested, because it's internal and does not change any API or other contracts.
Benchmark of this solution can be found here: https://gist.github.com/v-kolesnikov/36e63dd09b2eb5146c265cae6e378aa2

@yegor256
Copy link
Collaborator

yegor256 commented Aug 2, 2022

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Aug 2, 2022

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Aug 2, 2022

@rultor merge

@v-kolesnikov @yegor256 Oops, I failed. You can see the full log here (spent 1min)

com.jcraft.jsch.JSchException: socket is not established

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants