Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#610 Add zold node --nohup-log-rotate option #755

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

v-kolesnikov
Copy link

@v-kolesnikov v-kolesnikov commented May 8, 2019

Issue #610

@0crat 0crat added the scope label May 8, 2019
@0crat
Copy link
Collaborator

0crat commented May 8, 2019

Job #755 is now in scope, role is REV

@yegor256
Copy link
Collaborator

yegor256 commented May 8, 2019

@v-kolesnikov what happened with the description of the PR? Read this https://www.yegor256.com/2014/11/24/principles-of-bug-tracking.html

Also, where are the tests? How do you know it works?

@codecov-io
Copy link

Codecov Report

Merging #755 into master will increase coverage by <.01%.
The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #755      +/-   ##
==========================================
+ Coverage   33.88%   33.89%   +<.01%     
==========================================
  Files          76       76              
  Lines        3816     3824       +8     
==========================================
+ Hits         1293     1296       +3     
- Misses       2523     2528       +5
Impacted Files Coverage Δ
lib/zold/commands/node.rb 18.54% <27.27%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e0f693...9b76380. Read the comment docs.

@0crat
Copy link
Collaborator

0crat commented Aug 18, 2022

This pull request #755 is assigned to @anaumov/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @yegor256/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants