Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #326 - supporting upgrade files and version #496

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

emilianodellacasa
Copy link
Contributor

Solving issue #326 allowing Zold to upgrade itself using rb scripts.

I used the tests that had already been written but skipped at the moment.

Please note that I had to disable Eval check in Rubocop to avoid the code smell: in fact, using the "eval" function is a potential security breach, but it should be ok as we are executing only scripts that are in a specific directory of the repository.

@0crat
Copy link
Collaborator

0crat commented Oct 17, 2018

Job #496 is now in scope, role is REV

@0crat
Copy link
Collaborator

0crat commented Oct 17, 2018

@yegor256/z everybody who has role REV is banned at #496; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Oct 22, 2018

@yegor256/z everybody who has role REV is banned at #496; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Oct 27, 2018

@yegor256/z everybody who has role REV is banned at #496; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Oct 29, 2018

This pull request #496 is assigned to @tsuhachev/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @yegor256/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

@0crat
Copy link
Collaborator

0crat commented Nov 3, 2018

@tsuhachev/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants