Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing check for specmatic.json file to print API coverage #819

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

harikrishnan83
Copy link
Member

What:

Printing API coverage report with default settings even when specmatic.json is not available.

Why:

We cannot expect specmatic.json to be available where we are running the specmatic from command line.

How:

Removing check for specmatic.json in SpecmaticJUnitSupport which is preventing API coverage report from being printed when specmatic.json is not available.

Checklist:

@jaydeepk
Copy link
Collaborator

LGTM, Thanks Hari.

Copy link
Collaborator

@jaydeepk jaydeepk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , Thanks Hari.

@harikrishnan83 harikrishnan83 merged commit e2b67cb into main Nov 17, 2023
3 checks passed
@harikrishnan83 harikrishnan83 deleted the default_api_coverage_report branch November 17, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants