Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to oneOf generation and error messages #793

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

joelrosario
Copy link
Member

What:

  • There a bug fix to generation of oneOf. It was breaking when generative tests were on and out of 3 options only 1 matched the row. For now we simply don't generate if the row breaks. Need to discuss what to do if the example exists but the can't be used by some option in the oneOf.
  • Updated some language to say specification instead of contract.

Why:

  • The bug fix was required as without that generative tests were not working. It's more of a temp fix really to make sure generative tests can at least run, until we decide what's the real fix.
  • The language fix was needed as the older language was looking awkward in a recent video we recorded.

How:

Updated newBasedOn and negativeBasedOn in Anypattern, and some language strings where needed.

Checklist:

Issue ID:
Closes: #123

Copy link
Member

@harikrishnan83 harikrishnan83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@joelrosario joelrosario merged commit e7ee9f8 into main Oct 17, 2023
3 checks passed
@joelrosario joelrosario deleted the fixes_to_oneOf_generation branch October 17, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants