Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactive Examples Editor Error Highlighting Improvements #1528

Merged
merged 6 commits into from
Jan 6, 2025
Merged

Interactive Examples Editor Error Highlighting Improvements #1528

merged 6 commits into from
Jan 6, 2025

Conversation

samyakOO7
Copy link
Collaborator

@samyakOO7 samyakOO7 commented Jan 5, 2025 •
edited by harikrishnan83
Loading

The following issues are fixed as a part of this PR-

  • The error highlighting disappears on the line where we hover / is currently under focus. If it is the first line which has the error then focus by default is on that line, so no error highlights are seen.
  • The statement “Expected value but it was” is displayed for empty Strings. It should be Expected value but it was “”
  • When the editor is updated, the line decorations should continue to remain on the errors
  • Changed the line decoration to highlight only the part of a line that has errors so that users instinctively hover on chars to see the tooltip

Samy added 2 commits January 5, 2025 23:01
Resolved the following issues:
3c8bb54 
- The highlighted Specmatic issue disappears when the specific line is selected in the editor.
- The statement 'Expected value but it was' should be 'Expected value but it was empty()'.
- When the editor is updated, the line decorations point to the wrong line of error.
Resolved the following issues:
88de4ae 
- The CSS for the red line highlight is applied to the entire line, but the tooltip only appears when hovering over the text (tokens) in the editor.
@harikrishnan83 harikrishnan83 changed the title Code Mirror 6 - Issue Fixation Interactive Examples Editor Error Highlighting Improvements Jan 6, 2025
@harikrishnan83 harikrishnan83 self-requested a review January 6, 2025 14:53
@harikrishnan83 harikrishnan83 merged commit baf7321 into main Jan 6, 2025
2 checks passed
@harikrishnan83 harikrishnan83 deleted the CM-6-V4-IssueFixes branch January 6, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harikrishnan83 harikrishnan83 harikrishnan83 approved these changes

@joelrosario joelrosario Awaiting requested review from joelrosario

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samyakOO7 @harikrishnan83