Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add duckOthers option on iOS #745

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

EyadAlghamdi
Copy link

  • I have added duckOthers option for iOS

  • also updated the index.d.ts params here for setActive method. which was wrong

@EyadAlghamdi EyadAlghamdi mentioned this pull request Sep 3, 2021
8 tasks
RNSound/RNSound.m Outdated Show resolved Hide resolved
@denpy
Copy link

denpy commented Apr 3, 2022

@zmxv hey, I was wondering if there is anything I can do to get this PR merged? Tested it, and it worked as expected.

@glaydsoncosta
Copy link

Any change this can be reviewed and merged?

@Will-Mann-16
Copy link

Will-Mann-16 commented Oct 3, 2024

Heads up - we patched this into our repo, this causes a crash on Android. It was due to the number of arguments. A fix we did:

Sound.setCategory = function(value, mixWithOthers = false, duckOthers = false) {
  if (!IsWindows) {
    if(IsAndroid) {
      RNSound.setCategory(value, mixWithOthers);
    } else {
      RNSound.setCategory(value, mixWithOthers, duckOthers);
    }
  }
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants