Remove duplicate Album and ExternalIDs fields from FullTrack #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flimzy
force-pushed
the
remove_dupe_field
branch
from
0d3e376 to
c202ff7
Compare
They're both already present in SimpleTrack, and in the case of ExternalIDs, in a more convenient form. By putting the duplicate in FullTrack, SimpleTrack is rendered invalid/incomplete (since the json tags on the embedded fields are shadowed), and also use a less useful type (map[string]string, rather than TrackExternalIDs).
flimzy
force-pushed
the
remove_dupe_field
branch
from
c202ff7 to
d861bdb
Compare
flimzy
changed the title
strideynet
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They're both already present in SimpleTrack, and in the case of ExternalIDs, in a more convenient form. By putting the duplicate in FullTrack, SimpleTrack is rendered invalid/incomplete (since the json tags on the embedded fields are shadowed), and also use a less useful type (map[string]string, rather than TrackExternalIDs).
This is, of course, a breaking change, and should target v3.