Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: Avoid an implicit int in the IPv6 test #220

Open
wants to merge 1 commit into
base: 3_5
Choose a base branch
from

Conversation

fweimer-rh
Copy link

Otherwise, the test fails unconditionally with compilers that do not support implicit ints (a language feature that was removed with the C99 language revision).

Related to:

Copy link
Contributor

@prajwaltr93 prajwaltr93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good, thanks for the PR. can you point to your MR to 3_5 instead of master. currently it's not stable.

prajwaltr93
prajwaltr93 previously approved these changes Apr 19, 2023
@fweimer-rh fweimer-rh changed the base branch from master to 3_5 April 19, 2023 09:21
@fweimer-rh fweimer-rh dismissed prajwaltr93’s stale review April 19, 2023 09:21

The base branch was changed.

Otherwise, the test fails unconditionally with compilers that
do not support implicit ints (a language feature that was removed with
the C99 language revision).
@fweimer-rh
Copy link
Author

changes look good, thanks for the PR. can you point to your MR to 3_5 instead of master. currently it's not stable.

Should be properly retargeted now.

fweimer-rh added a commit to fweimer-rh/amanda that referenced this pull request Nov 28, 2023
Avoid an implicit int.  Otherwise, the test fails unconditionally with
compilers that do not support implicit ints (a language feature that
was removed with the C99 language revision).

Submitted upstream: <zmanda#220>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants