Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of the function
file_lock_write()
looks slightly strange. The library functiong_strdup()
used inside doesn't consider the length of the duplicated data. However, the size of thedata
parameter is restricted by the third parameterlen
, so its value must limit the number of bytes copied during duplication.That patch corrects the test function
inc_counter()
, but it looks suspicious to me because it terminates the character value by a zero character instead of checking how the functionfile_lock_write()
works in case thelen
parameter equals one and a string is not terminated by a zero character.