Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: i18n for undo messages and fix some missing #30

Merged
merged 5 commits into from
Sep 5, 2023

Conversation

wafarm
Copy link
Contributor

@wafarm wafarm commented Sep 5, 2023

Description/描述

Added i18n support for feedback messages. GithubAuthScreen wasn't changed.

Related Issues/相关的 issue

Related to #29

Checklist/清单

  • The issues this PR addresses are related to each other/此 PR 解决的 issue 是相关的
  • My changes are all related to the related issue above/我的修改都与上方的相关 issue 有关
  • My changes generate no new warnings/我的修改没有产生新的警告
  • My code builds and runs on my machine/我的代码在我的电脑上可以编译和运行
  • I documented my code/我已经为我的代码添加了注释/文档

@Cubik65536
Copy link
Collaborator

Looks great so far, btw put this PR as draft if it’s not done yet.

@wafarm
Copy link
Contributor Author

wafarm commented Sep 5, 2023

Looks great so far, btw put this PR as draft if it’s not done yet.

It's already done. But I will add GithubAuthScreen if needed.

@zly2006
Copy link
Owner

zly2006 commented Sep 5, 2023

It's already done. But I will add GithubAuthScreen if needed.

Please dont do that. this screen should be rewrite with LibGUI later.

@zly2006 zly2006 changed the title feat: i18n feat: i18n for undo messages and fix some missing Sep 5, 2023
Copy link
Owner

@zly2006 zly2006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not complete. please fix following:

com.github.zly2006.reden.mixin.chat.ChatScreenMixin

com.github.zly2006.reden.access.PlayerData.UndoRecord.Cause

@wafarm wafarm requested a review from zly2006 September 5, 2023 14:23
Copy link
Collaborator

@Cubik65536 Cubik65536 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cubik65536 Cubik65536 requested a review from zly2006 September 5, 2023 14:52
@zly2006 zly2006 merged commit 25264b8 into zly2006:1.20 Sep 5, 2023
@Cubik65536
Copy link
Collaborator

@zly2006 I do recommend you to do a beta release for this.

@zly2006
Copy link
Owner

zly2006 commented Sep 5, 2023 via email

@Cubik65536
Copy link
Collaborator

You can do it yourself (

Cool, I'll do it :)

@wafarm wafarm deleted the i18n branch September 16, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants