-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: i18n for undo messages and fix some missing #30
Conversation
Looks great so far, btw put this PR as draft if it’s not done yet. |
It's already done. But I will add |
Please dont do that. this screen should be rewrite with LibGUI later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not complete. please fix following:
com.github.zly2006.reden.mixin.chat.ChatScreenMixin
com.github.zly2006.reden.access.PlayerData.UndoRecord.Cause
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zly2006 I do recommend you to do a beta release for this. |
You can do it yourself (
|
Cool, I'll do it :) |
Description/描述
Added i18n support for feedback messages. GithubAuthScreen wasn't changed.
Related Issues/相关的 issue
Related to #29
Checklist/清单