feat: attest to negative values in da verifier + make calls to accounts updatable. #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethan-crypto
changed the title
da notebook *adjusted 1l_tahn output value in input.json
limit in py integration tests *rmv settings path in setup-test-evm
initialization.
alexander-camuto
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously one could only attest to data from view functions that return uint256 values. This PR introduces a breaking change: All view functions must now return int256 values, supporting both negative and positive inputs. I have also added more comments to the da verifier to help folks understand exactly what it's doing and how its opinionated.