Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add webauthn tutorial #65

Merged
merged 26 commits into from
Sep 24, 2024
Merged

feat: add webauthn tutorial #65

merged 26 commits into from
Sep 24, 2024

Conversation

sarahschwartz
Copy link
Contributor

@sarahschwartz sarahschwartz commented Sep 5, 2024 •
edited
Loading

This PR:

  • adds a tutorial to demonstrate how to sign transactions with webauthn & validate with the P256Verify precompile
  • includes a test for running the tutorial

@sarahschwartz sarahschwartz self-assigned this Sep 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit a758bf0):

https://community-cookbook-staging--pr65-sarah-p256-verify-tu-a0rtx101.web.app

(expires Tue, 01 Oct 2024 19:24:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1b876338aafcf55b4a02f1877984e116731756b1

@sarahschwartz sarahschwartz marked this pull request as ready for review September 13, 2024 18:45
@sarahschwartz sarahschwartz requested a review from a team as a code owner September 13, 2024 18:45
dutterbutter
dutterbutter reviewed Sep 13, 2024
View reviewed changes
Copy link
Contributor

@dutterbutter dutterbutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome work!

code/webauthn/contracts/deploy/deploy.ts Outdated Show resolved Hide resolved
code/webauthn/contracts/package.json Outdated Show resolved Hide resolved
code/webauthn/contracts/package.json Show resolved Hide resolved
code/webauthn/frontend/package.json Show resolved Hide resolved
content/tutorials/signing-transactions-with-webauthn/30.building-the-frontend.md Show resolved Hide resolved
content/tutorials/signing-transactions-with-webauthn/_dir.yml Outdated Show resolved Hide resolved
@sarahschwartz sarahschwartz added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 13, 2024
@cpb8010 cpb8010 requested review from cpb8010 and removed request for vladbochok September 18, 2024 23:29
cpb8010
cpb8010 reviewed Sep 19, 2024
View reviewed changes
Copy link

@cpb8010 cpb8010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments, rest looks great!

code/webauthn/frontend/src/pages/api/get-registration-options.ts Show resolved Hide resolved
code/webauthn/contracts/contracts/Account.sol Show resolved Hide resolved
code/webauthn/contracts/contracts/Account.sol Show resolved Hide resolved
code/webauthn/frontend/public/vercel.svg Outdated Show resolved Hide resolved
code/webauthn/frontend/src/pages/create-account.tsx Show resolved Hide resolved
code/webauthn/frontend/utils/webauthn.ts Show resolved Hide resolved
code/webauthn/frontend/utils/string.ts Show resolved Hide resolved
public/videos/webauthn-demo.mp4 Outdated Show resolved Hide resolved
tests/configs/signing-txns-with-webauthn.ts Outdated Show resolved Hide resolved
code/webauthn/frontend/src/pages/mint.tsx Show resolved Hide resolved
@sarahschwartz sarahschwartz changed the title feat: add code imports and webauthn tutorial feat: add webauthn tutorial Sep 23, 2024
cpb8010
cpb8010 previously approved these changes Sep 23, 2024
View reviewed changes
Copy link

@cpb8010 cpb8010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒 🥳

bxpana
bxpana approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@bxpana bxpana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTM 🔥

@sarahschwartz sarahschwartz merged commit 888b43c into main Sep 24, 2024
14 checks passed
@sarahschwartz sarahschwartz deleted the sarah/p256-verify-tutorial branch September 24, 2024 20:09
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asgarovf asgarovf asgarovf left review comments

@vladbochok vladbochok vladbochok left review comments

@dutterbutter dutterbutter dutterbutter left review comments

@uF4No uF4No uF4No left review comments

@itsacoyote itsacoyote itsacoyote left review comments

@bxpana bxpana bxpana approved these changes

@cpb8010 cpb8010 cpb8010 left review comments

Assignees

@sarahschwartz sarahschwartz

Labels
documentation Improvements or additions to documentation enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sarahschwartz @itsacoyote @uF4No @cpb8010 @dutterbutter @vladbochok @bxpana @asgarovf