Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add erc20 paymaster test and refactor testing #38

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

sarahschwartz
Copy link
Contributor

@sarahschwartz sarahschwartz commented Aug 6, 2024

This PR:

  • adds a test for the custom erc20 paymaster tutorial
  • adds types for each supported test action
  • refactors the testing framework to use a config file for the step details instead of putting everything in the span element. This way the details of each step is type checked.

@sarahschwartz sarahschwartz self-assigned this Aug 6, 2024
@sarahschwartz sarahschwartz changed the title test: add erc20 paymaster test and refactor testing feat: add erc20 paymaster test and refactor testing Aug 6, 2024
Copy link

github-actions bot commented Aug 6, 2024

Visit the preview URL for this PR (updated for commit e032de7):

https://community-cookbook-staging--pr38-sarah-add-tests-23kpsh8m.web.app

(expires Tue, 20 Aug 2024 20:32:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1b876338aafcf55b4a02f1877984e116731756b1

@sarahschwartz sarahschwartz marked this pull request as ready for review August 7, 2024 21:49
@sarahschwartz sarahschwartz requested a review from a team as a code owner August 7, 2024 21:49
itsacoyote
itsacoyote previously approved these changes Aug 9, 2024
Copy link
Contributor

@itsacoyote itsacoyote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a curious question, otherwise looks good to me!

content/tutorials/erc20-paymaster/10.index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@itsacoyote itsacoyote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@sarahschwartz sarahschwartz merged commit 5c6b7b6 into main Aug 13, 2024
11 checks passed
@sarahschwartz sarahschwartz deleted the sarah/add-tests branch August 13, 2024 22:04
Copy link

🎉 This issue has been resolved in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants