Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): allow setting external secure #389

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

muhlemmer
Copy link
Contributor

This change adds the possibility to set an external secure flag to the Authenticator. This allows creating logout URLs with https protocol when the service is behind a reverse proxy.

Closes #285

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@muhlemmer muhlemmer requested a review from livio-a October 8, 2024 10:05
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 0.05%. Comparing base (bfb0be0) to head (53cb67a).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/authentication/authenticate.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #389   +/-   ##
=====================================
  Coverage   0.05%   0.05%           
=====================================
  Files        127     127           
  Lines      92980   92983    +3     
=====================================
  Hits          47      47           
- Misses     92930   92933    +3     
  Partials       3       3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@livio-a livio-a merged commit 324d8db into main Oct 9, 2024
7 of 8 checks passed
@livio-a livio-a deleted the feat-external-secure branch October 9, 2024 07:16
Copy link
Contributor

github-actions bot commented Oct 9, 2024

🎉 This PR is included in version 3.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v3.0.0-next.2] Post Logout Redirect URI proto set incorrectly when behind TLS-terminating reverse proxy
2 participants