Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: password reset #225

Merged
merged 12 commits into from
Oct 17, 2024
Merged

fix: password reset #225

merged 12 commits into from
Oct 17, 2024

Conversation

peintnermax
Copy link
Member

@peintnermax peintnermax commented Oct 15, 2024

Partial of #186
Partial of #199

This PR implements an additional page on /password/set to set a password for the user.
A user can invoke it with a code which can be triggered from the password page.
This also removes the passkey setup temporarily to reduce decision complexity on the loginname page

Screenshot 2024-10-16 at 16 30 48

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • Vitest unit tests ensure that components produce expected outputs on different inputs.
  • Cypress integration tests ensure that login app pages work as expected. The ZITADEL API is mocked.
  • No debug or dead code
  • My code has no repetitions

Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
typescript-login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 8:20am

@peintnermax peintnermax changed the base branch from main to qa October 17, 2024 08:58
@peintnermax peintnermax marked this pull request as ready for review October 17, 2024 08:59
@peintnermax peintnermax merged commit fedd4d2 into qa Oct 17, 2024
6 checks passed
@peintnermax peintnermax deleted the reset-pwd branch October 17, 2024 08:59
@peintnermax peintnermax mentioned this pull request Oct 17, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant