Improve ErrorKind in ZipError to io::Error conversion

zip-rs · Dec 22, 2023 · bc3bd14 · bc3bd14
1 parent 3e88fe6
commit bc3bd14
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/result.rs b/src/result.rs
@@ -78,7 +78,14 @@ impl ZipError {
 
 impl From<ZipError> for io::Error {
     fn from(err: ZipError) -> io::Error {
-        io::Error::new(io::ErrorKind::Other, err)
+        let kind = match &err {
+            ZipError::Io(err) => err.kind(),
+            ZipError::InvalidArchive(_) => io::ErrorKind::InvalidData,
+            ZipError::UnsupportedArchive(_) => io::ErrorKind::Unsupported,
+            ZipError::FileNotFound => io::ErrorKind::NotFound,
+        };
+
+        io::Error::new(kind, err)
     }
 }