Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix java.time.Instant tests #182

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Fix java.time.Instant tests #182

merged 1 commit into from
Oct 30, 2023

Conversation

guizmaii
Copy link
Member

@guizmaii guizmaii commented Oct 30, 2023 •
edited
Loading

Dumb copy/paste mistake 😭

This comment made me doubt my code: pgjdbc/pgjdbc#1325 (comment)
Especially this line:

As you can see the time java.sql.Timestamp -> java.time.Instant conversion depends on the JVM default time zone.

because it was what I was experiencing and why I had to set the JVM default timezone before starting the tests, which was, as @987Nabil was pointing out, weird.

Thanks @987Nabil for your review 🙂

@guizmaii guizmaii mentioned this pull request Oct 30, 2023
Merged
@adamgfraser adamgfraser merged commit dea7e36 into zio:main Oct 30, 2023
15 checks passed
@guizmaii guizmaii deleted the fix_instant_decoder_encoder_test branch October 31, 2023 07:20
@vladimir-lu vladimir-lu mentioned this pull request Aug 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgfraser adamgfraser adamgfraser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guizmaii @adamgfraser