remove Setter.arraySetter
#180
Merged
+2
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
I want to interpolate in postgres arrays as parameters - not explode them as multiple parameters.
oyvindberg
force-pushed
the
remote-array-setter
branch
from
1f7dfab to
186248f
Compare
guizmaii
approved these changes
Oct 30, 2023
adamgfraser
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to interpolate in postgres arrays as parameters - not explode them as multiple parameters. It's basically impossible to implement support for
Arraycolumns with this implicit present.Other libraries like anorm and doobie have settled on this distinction already, scala sequences are exploded in the sql and
Arrays are passed right through (with the right typeclass instances, of course). I suggest we do the same for zio-jdbc.This is of course a breaking change, but probably doesn't affect many people. The workaround will be to say
myArray.toListor similar