Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added skipPageHeightSetter option to circumvent #25 #83

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jankcat
Copy link
Contributor

@jankcat jankcat commented Jan 22, 2018

I was seeing some weird issues on pages, and commenting out the pageHeight command seemed to solve it.

Example page: https://www.mcdonalds.com/us/en-us.html
On this example page, the entire footer would disappear when run on Chrome-Windows 10-Latest
Commenting out the pageHeight command stopped the issue, but brings the whitespace back to the bottom of the page, which is a compromise worth having in order to capture the footer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant