Code

Spent process 2024#783

Code

Merged

fluidvanadium merged 213 commits intozingolabs:devzingolabs/zingolib:devfrom fluidvanadium:spent_process_2024fluidvanadium/zingolib:spent_process_2024Copy head branch name to clipboardJan 25, 2024

+2,894-2,299

Commits

Commits on Nov 15, 2023

• moved json dependency to workspace. todo: remove json in favour of serde_json

  fluidvanadium

  committed
  e0d1b71

Commits on Nov 21, 2023

• Merge branch 'cleanup_height_from_transparent_note' into fluidev

  fluidvanadium

  committed
  69e0728

• merged Cargo.toml

  fluidvanadium

  committed
  50c9fa4

• Merge remote-tracking branch 'fluid/improve_zingoliberror_metadataunderflow' into fluidev

  fluidvanadium

  committed
  ce0ccf8

• Merge remote-tracking branch 'fluid/updatenotes_obtain_lock_once' into fluidev

  fluidvanadium

  committed
  720be06

Commits on Nov 26, 2023

• added zingo-status

  fluidvanadium

  committed
  2540bf0

• added dep to Cargo.toml

  fluidvanadium

  committed
  ab840fa

• Merge remote-tracking branch 'labs/dev' into confenum_5

  fluidvanadium

  committed
  7855cdc

• added status to TransactionMetadata

  fluidvanadium

  committed
  b03957d

• assign status when modifying

  fluidvanadium

  committed
  9a95136

• save using status

  fluidvanadium

  committed
  9d7ecff

• replaced unconfirmed in json

  fluidvanadium

  committed
  6185fdc

• caught merge- incompatibility

  fluidvanadium

  committed
  b19f23c

• replace summaries unconfirmed with status

  fluidvanadium

  committed
  063856f

• use status in write

  fluidvanadium

  committed
  a6b8ac3

• use status in get_notes for updating

  fluidvanadium

  committed
  1ab1a2f

• use status in clear_expired_mempool

  fluidvanadium

  committed
  a60de38

• remove TransactionMetadata.unconfirmed

  fluidvanadium

  committed
  1faef0c

• create_modify_get_transaction_metadata uses ConfirmationStatus

  fluidvanadium

  committed
  8a5427b

• error uses status

  fluidvanadium

  committed
  fec1aac

Commits on Nov 27, 2023

• changed enum variant names and used Broadcast in read case

  fluidvanadium

  committed
  b750096

• added backwards compatibility case

  fluidvanadium

  committed
  7d8e594

• used status instead of block_height in write wallet. 25 remaining mentions

  Show description for 0db2703
  fluidvanadium

  committed
  0db2703

• use is_confirmed_before_or_at in get_user_balances

  fluidvanadium

  committed
  5364b4a

• added sync_with_timeout and a test

  fluidvanadium

  committed
  b92d629

• increased chainheight

  fluidvanadium

  committed
  b996e6e

• upgraded and renamed test

  fluidvanadium

  committed
  fc89ba8

• added biased to timeout function

  fluidvanadium

  committed
  4fbd932

• Merge remote-tracking branch 'labs/dev' into timed_sync_interrupt_test

  fluidvanadium

  committed
  827e6cb

• verified balance uses status confirmed

  fluidvanadium

  committed
  ef47e45

• only spendable if confirmed

  fluidvanadium

  committed
  225ce33

• block height coerced for valuetransfer

  fluidvanadium

  committed
  a081adb

Commits on Dec 5, 2023

• Merge remote-tracking branch 'labs/dev' into timed_sync_interrupt_test

  fluidvanadium

  committed
  46256a3

• Merge branch 'error_test_panic' into timed_sync_interrupt_test

  fluidvanadium

  committed
  21d2656

• Merge branch 'error_test_panic' into timed_sync_interrupt_test

  fluidvanadium

  committed
  9665725

• updated non_empty_frontier handling

  fluidvanadium

  committed
  f4f55fb

• updated timed_interrupt test

  fluidvanadium

  committed
  7d13832

Commits on Dec 6, 2023

• Merge remote-tracking branch 'labs/dev' into confenum_8

  fluidvanadium

  committed
  1bb331f

• Merge remote-tracking branch 'labs/dev' into timed_sync_interrupt_test

  fluidvanadium

  committed
  e49178d

• all valuetransfers use coerced get_height

  fluidvanadium

  committed
  7cad350

• added broadcast_unconfirmed_after helper

  fluidvanadium

  committed
  692c6b8

• unverified balance uses broadcast_unconfirmed helper

  fluidvanadium

  committed
  010514e

• get_first_transaction_block uses coerced height

  fluidvanadium

  committed
  bf83a72

• fix_spent_at_height uses get_height

  fluidvanadium

  committed
  6b10e30

• list transparent_notes uses get_height

  fluidvanadium

  committed
  5ea26d7

• list orchard_notes uses get_height

  fluidvanadium

  committed
  5d4582a

• list orchard notes uses confirmed_after_or_at to verify confirmation status

  fluidvanadium

  committed
  143601c

• list sapling_notes uses get_height

  Show description for fc8e341
  fluidvanadium

  committed
  fc8e341

• get_notes_for_updating uses is_confirmed_before_or_at

  fluidvanadium

  committed
  cfcc2f5

• get_notes_for_updating uses is_confirmed_before_or_at for sapling

  fluidvanadium

  committed
  b5765c4

• clear_expired_mempool uses status.is_expired

  fluidvanadium

  committed
  77a6967

• remove txns (reorg) removes confirmed_after or at and broadcast_unconfirmed_after

  fluidvanadium

  committed
  1d5e9d1

• highest txid sanity rewrite

  fluidvanadium

  committed
  1b3d62d

• removed TransactionMetadata.block_height

  fluidvanadium

  committed
  1d625bf

• blockheight placeholder is low

  fluidvanadium

  committed
  f7a3f21

• ignore bitmask warnings

  fluidvanadium

  committed
  7e5d454

• thanx to clippy for simplified match

  fluidvanadium

  committed
  e3b5c46

• removed unused argument

  fluidvanadium

  committed
  437fc54

• add_new_spent_internal takes status

  fluidvanadium

  committed
  06c7d19

• add_new_spent uses ConfirmationStatus

  fluidvanadium

  committed
  9b3718d

• organized TransactionMetadataSet impl block

  fluidvanadium

  committed
  fff7973

• update comment

  fluidvanadium

  committed
  9cd141a

• remove extra allow(clippy)

  fluidvanadium

  committed
  e24b37a

• revert change to TMS field name

  fluidvanadium

  committed
  8ace3e5

• added comment

  fluidvanadium

  committed
  c962c77

Commits on Dec 10, 2023

• resolved merge conflict for deleted function

  fluidvanadium

  committed
  ccce1e8

• added transactions submodule read_write

  fluidvanadium

  committed
  2cc625c

• broke transactions.rs into modules

  fluidvanadium

  committed
  808839b

• merged confenum_9, but did not changes to get_highest. i will unit-test-tize a new method of the TMS for that

  fluidvanadium

  committed
  ae2ca1e

• added get_highest_txid to transaction_metadata

  fluidvanadium

  committed
  5ed75bf

• removed a truthidublisduous field and replaced it with a method

  fluidvanadium

  committed
  dbb7a06

• added a unit test for get_some_txid_from_highest

  fluidvanadium

  committed
  7cd1a38

• renamed add_new_spent to found_spent_nullifier. this function is called when we discover an outgoing transaction. it adds the discovered outgoing transaction to the database

  fluidvanadium

  committed
  f492e2f

• renamed parameters

  fluidvanadium

  committed
  537d884

• fixed test. get_some_txid_from_highest_wallet_block no longer gets broadcast sends that have never been confirmed

  fluidvanadium

  committed
  26e3884

• brought variable names in line

  fluidvanadium

  committed
  a61b811

Commits on Dec 11, 2023

• variable names

  fluidvanadium

  committed
  be412d2

• refactoring process_spent

  fluidvanadium

  committed
  026c5d3

• \removed process_note_spent

  fluidvanadium

  committed
  92c2d69

• reforged mark_spent

  fluidvanadium

  committed
  5ca2e75

• added NoSuchNullifierInTx error variant

  fluidvanadium

  committed
  c8c9645

• added error handling to mark_note_as_spent

  fluidvanadium

  committed
  adbfb3b

• Merge remote-tracking branch 'labs/dev' into timed_sync_interrupt_test

  fluidvanadium

  committed
  2abdb0a

• found_spent_nullifier uses ZingoLibResult

  fluidvanadium

  committed
  e6f9eb1

• merged error handler fix

  fluidvanadium

  committed
  d2d3177

• uses handle_or_panic to panic in debug

  fluidvanadium

  committed
  2bc395d

• merged timed_sync_interrupt_test

  fluidvanadium

  committed
  2156497

• update test dbgs

  fluidvanadium

  committed
  1cb5a45

• revert error handling

  fluidvanadium

  committed
  fc54f7f

• reverted error experiment for clippy

  fluidvanadium

  committed
  166b3ec

• test twiddles

  fluidvanadium

  committed
  61df2a5

• test twiddles

  fluidvanadium

  committed
  719cb53

• removed test and dbg for PR

  fluidvanadium

  committed
  699bb82

• removed unused parameter

  fluidvanadium

  committed
  1953aa1

• a snarky comment

  fluidvanadium

  committed
  02687bc

• is_broadcast is a ConfirmationStatus method

  fluidvanadium

  committed
  f708023

• scan_bundle uses status

  fluidvanadium

  committed
  aa9239e

• scan_bundle uses status

  fluidvanadium

  committed
  139fa25

• Merge remote-tracking branch 'labs/dev' into confenum_9

  fluidvanadium

  committed
  bd60a4b

• fixed comment

  fluidvanadium

  committed
  2fc4467

• streamlined confenum

  fluidvanadium

  committed
  7d3d29b

• merged Cargo.toml

  fluidvanadium

  committed
  6bbefcf

• removed unnecessary json

  fluidvanadium

  committed
  cca770c

• unverified transactions have Not been confirmed more than 100 times

  fluidvanadium

  committed
  aa7b61c

Commits on Dec 12, 2023

• merged updated confenum

  fluidvanadium

  committed
  fe7b7c3

• Merge branch 'confenum_9' into refactor_transactions

  fluidvanadium

  committed
  ad6df16

• remove json dep from workspace

  fluidvanadium

  committed
  ac359d0

• merged up

  fluidvanadium

  committed
  f9ee465

• removed redundant check

  fluidvanadium

  committed
  65d5202

Commits on Dec 13, 2023

• removed redundant check

  fluidvanadium

  committed
  3c81b2e

• Merge branch 'refactor_transactions' into spent_process_pr

  fluidvanadium

  committed
  e3b28aa

Commits on Jan 9, 2024

• merged to latest dev

  fluidvanadium

  committed
  11a3aca

Commits on Jan 11, 2024

• unignored test

  fluidvanadium

  committed
  fd217a1

• fixed log

  fluidvanadium

  committed
  247fc3a

Commits on Jan 15, 2024

• added smaller chain test

  Oscar-Pepper

  committed
  5925916

• upgraded test

  fluidvanadium

  committed
  bea1209

• upgraded comments

  fluidvanadium

  committed
  2d6be9c

• add_new_taddr_output uses status

  fluidvanadium

  committed
  3bdbd31

• improved test

  fluidvanadium

  committed
  f510498

• Merge branch 'spent_process_2024' into sp2024_purge_unconfirmed

  fluidvanadium

  committed
  ecd0f2b

• rearranged status var assignment

  fluidvanadium

  committed
  8bd92a5

• mark_txid_utxo_spent uses confirmation_status_internally

  fluidvanadium

  committed
  fdff4aa

• mark_txid_utxo_spent uses confirmation_status as parameter

  fluidvanadium

  committed
  0f61e15

• parameter name specified

  fluidvanadium

  committed
  979bcdf

• removed useless tuple element

  fluidvanadium

  committed
  7517c6f

• add_taddr_spent uses status

  fluidvanadium

  committed
  8d001b6

• scan_transparent bundle uses status. tODO: replace presumming (which could mess up the value if duplicated) with query check. tODO: replace mark_change with query check.

  fluidvanadium

  committed
  57b5b9b

• execute_bundlescans_internal uses status

  fluidvanadium

  committed
  7f44194

• scan_full_tx uses ConfirmationStatus

  fluidvanadium

  committed
  40fb883

• WIP note refactor

  fluidvanadium

  committed
  191db89

• added grpc delay to trigger just before the call, changed network interupt test and added some helpers

  Oscar-Pepper

  committed
  096de07

• refactored NoteInterface

  fluidvanadium

  committed
  30110c1

• renamed TransactionMetadata to TransactionRecord

  fluidvanadium

  committed
  44e2933

• refactored TransactionRecord into a mod

  fluidvanadium

  committed
  d08a7d2

• refactoring TransactionMetadataSet

  fluidvanadium

  committed
  a609dc6

• refactored transaction_record out of data

  fluidvanadium

  committed
  9c993f3

• sorted transaction_record into 3 impl blocks

  fluidvanadium

  committed
  1d3c8af

• Switch output_index to option instead of placeholder, add panic if placeholder collides with real value

  AloeareV

  committed
  e23581e

• moved txid_from_slice into utils

  fluidvanadium

  committed
  1ec447b

• added new pub fn to TransactionRecord

  fluidvanadium

  committed
  50b722f

• use get_transparent_value_spent method

  fluidvanadium

  committed
  dba8f44

• turn assert into zingolib error

  AloeareV

  committed
  fcd0428

• add_new_note uses ConfirmationStatus

  fluidvanadium

  committed
  8a23af5

• fix unused result

  AloeareV

  committed
  92c5a1a

• Merge remote-tracking branch 'labs/dev' into spent_process_2024

  fluidvanadium

  committed
  e98b5f8

• fixed unit test

  fluidvanadium

  committed
  9a958ee

• remove documentation boilerplate

  zancas

  committed
  aeb15df

• run cargo update

  zancas

  committed
  109f8cb

• start documenting zingo-status

  zancas

  committed
  d147a32

• boilerplate doc-tests (ChatGPT generated) showing literal use-cases

  zancas

  committed
  81d8539

• bread-crumb for state set

  zancas

  committed
  eccc772

• whitespace cleanup

  zancas

  committed
  b9c589d

Commits on Jan 16, 2024

• note this test assumes that the code is correctgit add -p

  zancas

  committed
  093ebf0

• remove is_broadcast in favor of if let CS::Broad..

  zancas

  committed
  cb967fc

• propose removing is_broadcast

  zancas

  committed
  c8d560d

• start adding unit-test of write

  zancas

  committed
  960a19e

• wip

  zancas

  committed
  8081891

• start unit-test framework

  zancas

  committed
  61750fd

• fix use paths

  zancas

  committed
  8da30ee

• progress on builder/mocks

  zancas

  committed
  ce42b4c

• first draft of unit-test framework.. builds

  zancas

  committed
  26ae4bd

• draft test showing fee and send-to-self inconsistencies

  Oscar-Pepper

  committed
  37f8d0a

• remove ChatGPT boilerplate

  zancas

  committed
  57c51c9

• mv code into existing test_framework.rs

  zancas

  committed
  388a148

• (for now at least) the test framework is pub(crate) and cfg(test)

  zancas

  committed
  9eb68a8

• draft 2 send-to-self bug test

  Oscar-Pepper

  committed
  cdde5ff

• first draft of builder-use in test works

  zancas

  committed
  37dafa5

• rename note to notes

  zancas

  committed
  c24fa61

• mv build_method macro definition

  zancas

  committed
  4d22114

• explicit is better than implicit: https://zen-of-python.info/explicit-is-better-than-implicit.html#2

  zancas

  committed
  a7441a6

• make wallet.rs more explicit, wrt notes

  zancas

  committed
  1c194f3

• make which 'note' is referenced explicit

  zancas

  committed
  954144c

• migrate TransparentNote from data.rs. to notes.rs, use explicit qualifiers

  zancas

  committed
  7677e07

• draft 3

  Oscar-Pepper

  committed
  4ae11e1

• Merge pull request #6 from zancas/spent_process_2024

  Show description for e0e291c
  fluidvanadium

  authored
  e0e291c

• comment clarification

  fluidvanadium

  committed
  6ef27ba

• fixed uses

  fluidvanadium

  committed
  bfae961

• Update zingolib/src/wallet/transaction_record.rs

  Show description for 9926e38
  

  fluidvanadium

  and

  AArnott

  authored
  9926e38

• use method again

  fluidvanadium

  committed
  51e7e5d

• fix clippy, nnmd->note

  AloeareV

  committed
  dfb1c60

• Merge remote-tracking branch 'fluid/spent_process_2024' into spent_process_2024

  AloeareV

  committed
  554a2aa

• update comments

  fluidvanadium

  committed
  3563ec3

• reverted to method use

  fluidvanadium

  committed
  f07d6af

• merged

  fluidvanadium

  committed
  198e7ca

• finished test

  Oscar-Pepper

  committed
  5e878fa

• fixed balance assert

  Oscar-Pepper

  committed
  6c5ee18

• make test slightly more concise

  zancas

  committed
  1f1687e

• make test slightly more succinct

  zancas

  committed
  7d33cb1

Commits on Jan 17, 2024

• finalised shielded note marked as change test

  Oscar-Pepper

  committed
  d025391

• fix rogue l that made it into code!

  Oscar-Pepper

  committed
  d85630e

• added third grpc call that causes bug, commented out as test takes long time

  Oscar-Pepper

  committed
  3dce531

• Merge branch 'dev' into spent_process_2024

  zancas

  committed
  fe4be0c

• rm a .gitinclude

  zancas

  committed
  14afbcc

• fix clippy and extend delay time

  Oscar-Pepper

  committed
  7791edd

• Merge branch 'shielded_note_marked_as_change_test' into spent_process_2024

  zancas

  committed
  0db74ec

• Merge pull request #7 from zancas/spent_process_2024

  Show description for 8f633ec
  fluidvanadium

  authored
  8f633ec

Commits on Jan 18, 2024

• unignored change test

  fluidvanadium

  committed
  793224a

• updated binary location error message

  fluidvanadium

  committed
  b79f9c7

• re-ignored test

  fluidvanadium

  committed
  093c394

• git included test_binaries/bins directory

  fluidvanadium

  committed
  f6b238e

• added unit tests to transaction_record. currently, they assume new should return 0-values. they might be upgraded to look for Nones

  fluidvanadium

  committed
  14b4831

• ignored darkside test

  fluidvanadium

  committed
  0836639

• Merge branch 'unit_test_transaction_record' into spent_process_2024

  fluidvanadium

  committed
  f4608f4

• upgrade doc comments

  fluidvanadium

  committed
  17d6ff5

• added doc comments

  fluidvanadium

  committed
  9d189d7

• went over confirmation status, writing doc tests. found a misimplementation and fixed it. added comments where these methods are used in sync

  fluidvanadium

  committed
  191f19b

Commits on Jan 19, 2024

• reverted reorg change and write comment

  fluidvanadium

  committed
  b20c2c2

Commits on Jan 23, 2024

• added v28 wallet integration test

  fluidvanadium

  committed
  7431afa

• removed a comment that didnt make sense

  fluidvanadium

  committed
  1ad1046

• Merge branch 'v28_wallet_integration_test' into spent_process_2024

  fluidvanadium

  committed
  5774626

• removed use::*

  fluidvanadium

  committed
  c866869

Commits on Jan 24, 2024

• improved v28 wallet test with lightclient balance assertion

  fluidvanadium

  committed
  b303183

Commits on Jan 25, 2024

• Merge branch 'v28_wallet_integration_test' into spent_process_2024

  fluidvanadium

  committed
  61c9f84