Implement a reorg that removes an incoming transaction #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…saction Closes zingolabs#609 builds on top of zingolabs#593 Fix Clippy
Cargo FMT
Closes zingolabs#614 In this case the wallet receives a transaction and a reorg removes it from the chain. This can happen if the "best chain" does not contain that transaction, and the subsequent blocks don't include it either. 1. Setup w/ default dataset with a received transaction at `received_tx_height` 2. sync up to `received_tx_height` minus some blocks. 3. capture balance 4. sync up to `received_tx_height` or higher and capture txid of the received transaction 5. trigger the reorg that removes the received transaction from the chain 6. sync to chaintip (the wallet should recover from the reorg)7 7. verify that the balance is equal to step 3 and that the txid found on step 4 is not present anymore. uses dataset: zingolabs/darksidewalletd-datasets#14 Closes pacu/zcash-dev-rel-engineer#45
This was referenced Nov 23, 2023
zancas
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[https://github.com//issues/614] Implement a reorg that removes an incoming transaction
Closes #614
Builds atop #710
In this case the wallet receives a transaction and a reorg removes it
from the chain. This can happen if the "best chain" does not contain
that transaction, and the subsequent blocks don't include it either.
received_tx_heightreceived_tx_heightminus some blocks.received_tx_heightor higher and capture txid of the received transactionis not present anymore.
uses dataset: zingolabs/darksidewalletd-datasets#14
Closes pacu/zcash-dev-rel-engineer#45