Improve fee and change logic

[AloeareV]

Still in progress...some tests are now failing.

[fluidvanadium]

darn, i wish i could have beaten you to a failing test, but this should fix

[fluidvanadium]

wait hold on, i discovered something with a test that doesnt add up to my understanding!

[fluidvanadium]

okay, heres what
in the regtest case, calling get_transaction_fee :

[zingolib/src/wallet/data.rs:948] self.is_outgoing_transaction() = false
[zingolib/src/wallet/data.rs:949] self.total_value_spent() = 0
[zingolib/src/wallet/data.rs:950] self.value_outgoing() = 0
[zingolib/src/wallet/data.rs:950] self.total_change_returned() = 0
[zingolib/src/wallet/data.rs:948] self.is_outgoing_transaction() = true
[zingolib/src/wallet/data.rs:949] self.total_value_spent() = 625000000
[zingolib/src/wallet/data.rs:950] self.value_outgoing() = 1000
[zingolib/src/wallet/data.rs:950] self.total_change_returned() = 624989000
[zingolib/src/wallet/data.rs:948] self.is_outgoing_transaction() = true
[zingolib/src/wallet/data.rs:949] self.total_value_spent() = 625000000
[zingolib/src/wallet/data.rs:950] self.value_outgoing() = 1000
[zingolib/src/wallet/data.rs:950] self.total_change_returned() = 624989000
[zingolib/src/wallet/data.rs:948] self.is_outgoing_transaction() = false
[zingolib/src/wallet/data.rs:949] self.total_value_spent() = 0
[zingolib/src/wallet/data.rs:950] self.value_outgoing() = 0
[zingolib/src/wallet/data.rs:950] self.total_change_returned() = 0
[zingolib/src/wallet/data.rs:948] self.is_outgoing_transaction() = false
[zingolib/src/wallet/data.rs:949] self.total_value_spent() = 0
[zingolib/src/wallet/data.rs:950] self.value_outgoing() = 0
[zingolib/src/wallet/data.rs:950] self.total_change_returned() = 0
[zingolib/src/wallet/data.rs:948] self.is_outgoing_transaction() = false
[zingolib/src/wallet/data.rs:949] self.total_value_spent() = 0
[zingolib/src/wallet/data.rs:950] self.value_outgoing() = 0
[zingolib/src/wallet/data.rs:950] self.total_change_returned() = 0

[AloeareV]

okay, heres what in the regtest case, calling get_transaction_fee :

[zingolib/src/wallet/data.rs:948] self.is_outgoing_transaction() = false
[zingolib/src/wallet/data.rs:949] self.total_value_spent() = 0
[zingolib/src/wallet/data.rs:950] self.value_outgoing() = 0
[zingolib/src/wallet/data.rs:950] self.total_change_returned() = 0
[zingolib/src/wallet/data.rs:948] self.is_outgoing_transaction() = true
[zingolib/src/wallet/data.rs:949] self.total_value_spent() = 625000000
[zingolib/src/wallet/data.rs:950] self.value_outgoing() = 1000
[zingolib/src/wallet/data.rs:950] self.total_change_returned() = 624989000
[zingolib/src/wallet/data.rs:948] self.is_outgoing_transaction() = true
[zingolib/src/wallet/data.rs:949] self.total_value_spent() = 625000000
[zingolib/src/wallet/data.rs:950] self.value_outgoing() = 1000
[zingolib/src/wallet/data.rs:950] self.total_change_returned() = 624989000
[zingolib/src/wallet/data.rs:948] self.is_outgoing_transaction() = false
[zingolib/src/wallet/data.rs:949] self.total_value_spent() = 0
[zingolib/src/wallet/data.rs:950] self.value_outgoing() = 0
[zingolib/src/wallet/data.rs:950] self.total_change_returned() = 0
[zingolib/src/wallet/data.rs:948] self.is_outgoing_transaction() = false
[zingolib/src/wallet/data.rs:949] self.total_value_spent() = 0
[zingolib/src/wallet/data.rs:950] self.value_outgoing() = 0
[zingolib/src/wallet/data.rs:950] self.total_change_returned() = 0
[zingolib/src/wallet/data.rs:948] self.is_outgoing_transaction() = false
[zingolib/src/wallet/data.rs:949] self.total_value_spent() = 0
[zingolib/src/wallet/data.rs:950] self.value_outgoing() = 0
[zingolib/src/wallet/data.rs:950] self.total_change_returned() = 0

value_outgoing doesn't include the transaction fee, the fee is what's left when you subtract the value outgoing + change returned from the value spent. The behavior is correct, it's the name that's misleading. Any idea on what to call this function so that it's clear it doesn't include the fee?

[fluidvanadium]

non-outgoing transactions return all zeros... but we know this has not been the case in real wallets. leaving some open questions

what conditions cause TransactionMetadata.total_value_spent() to change?

add_spent_nullifier(

what conditions cause TransactionMetadata.value_outgoing() to change?
outgoing_tx_data is written i think also only one place
wallet/transactions.rs 870

add_outgoing_metadata(

what conditions cause TransactionMetadata.total_change_returned() to change?

TransactionMetadata.is_change()

i have not figured out where the latter is written

[AloeareV]

what conditions cause TransactionMetadata.total_change_returned() to change?

TransactionMetadata.is_change()

i have not figured out where the latter is written

The last one is written by transactions.rs mark_notes_as_change_for_pool

[fluidvanadium]

why does outgoing require parameters?

[AloeareV]

why does outgoing require parameters?

The parameters specify the human-readable part of the address encoding, which we need to check if the address string we sent to is derivable from our keys