Assertions mod #1081
Merged
Assertions mod #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluidvanadium
force-pushed
the
assertions_mod
branch
from
4060e03
to
a329a69
Compare
fluidvanadium
force-pushed
the
assertions_mod
branch
from
be63646
to
5481d33
Compare
fluidvanadium
force-pushed
the
assertions_mod
branch
from
5481d33
to
b29ddaf
Compare
fluidvanadium
force-pushed
the
assertions_mod
branch
from
65ba846
to
189ceb6
Compare
Oscar-Pepper
previously requested changes
May 17, 2024
zancas
approved these changes
May 17, 2024
zancas
approved these changes
May 17, 2024
zancas
dismissed
Oscar-Pepper’s stale review
Oscar will add a calculation to TransactionRecords that properly calculates the fee for that transaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these are assertions about whether a proposal was fulfilled, packaged up nicely