Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node app #42

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from
Draft

Node app #42

wants to merge 33 commits into from

Conversation

PythonFZ
Copy link
Member

@PythonFZ PythonFZ commented Sep 25, 2024

znsocket for JavaScript

  • add support for List in List / Dict in Dict references
  • callbacks
  • fix tests just returning "OK"
  • fix JEST_PATH
  • fix CI
  • createClient without new
  • typescript declartion (https://pauloe-me.medium.com/typescript-npm-package-publishing-a-beginners-guide-40b95908e69c)
  • one socketio client with different namespaces or check how to handle multiple namespace connections in general
  • test against redis using npm test . -t redis_native_* or similar and python - npm interface.
  • need the socket.off for react

@coveralls
Copy link

coveralls commented Sep 26, 2024

Pull Request Test Coverage Report for Build 11166371358

Details

  • 127 of 135 (94.07%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 95.365%

Changes Missing Coverage Covered Lines Changed/Added Lines %
znsocket/utils.py 63 71 88.73%
Totals Coverage Status
Change from base Build 10984069095: -0.4%
Covered Lines: 679
Relevant Lines: 712

💛 - Coveralls

@coveralls
Copy link

coveralls commented Sep 26, 2024

Pull Request Test Coverage Report for Build 11052561762

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.781%

Totals Coverage Status
Change from base Build 10984069095: 0.0%
Covered Lines: 613
Relevant Lines: 640

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants