Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save units in attrs of H5 #90

Merged
merged 13 commits into from
May 17, 2024
Merged

save units in attrs of H5 #90

merged 13 commits into from
May 17, 2024

Conversation

PythonFZ
Copy link
Member

@PythonFZ PythonFZ commented May 16, 2024

@PythonFZ PythonFZ linked an issue May 17, 2024 that may be closed by this pull request
Copy link

@M-R-Schaefer M-R-Schaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. But this will break existing IPS H5 files, right? Is there some sort of backward compatibility functionality?
If not it?s fine too, I just need to breace myself 😂

@PythonFZ
Copy link
Member Author

looks good. But this will break existing IPS H5 files, right? Is there some sort of backward compatibility functionality? If not it?s fine too, I just need to breace myself 😂

Reading should be fully backwards compatible

@PythonFZ PythonFZ merged commit aa6f9f4 into main May 17, 2024
4 of 5 checks passed
@PythonFZ PythonFZ deleted the fix-units branch May 17, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MDAnalysis can't read files
2 participants