Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌸 DesignLibrary: Layout is responsible for.... Layout... #2281

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

zspencer
Copy link
Member

@zspencer zspencer commented Mar 7, 2024

One of the things we've kept bumping into is that each page has to decide how wide it wants to be. That doesn't really seem sustainable or particularly necessary; so now the Layout takes care of:

  • Providing a Max-Width on every page
  • Ensuring the Layout is centered horizontally
  • Ensuring there is appropriate margin from the top of the screen

After

Screenshot 2024-03-06 at 6 08 02 PM

Before

Screenshot 2024-03-06 at 6 07 51 PM

- #1187
- #2271
- #2253

One of the things we've kept bumping into is that each page has to
decide how wide it wants to be. That doesn't really seem sustainable or
particularly necessary; so now the Layout takes care of:

- Providing a Max-Width on every page
- Ensuring the Layout is centered horizontally
- Ensuring there is appropriate margin from the top
  of the screen
@zspencer zspencer requested review from a team March 7, 2024 02:22
Copy link
Member

@anaulin anaulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@zspencer zspencer merged commit 7e24542 into main Mar 7, 2024
3 checks passed
@zspencer zspencer deleted the section/layout-should-always-be-spacey branch March 7, 2024 17:36
zspencer added a commit to zinc-collective/tobias that referenced this pull request Mar 25, 2024
…ective#2281)

- zinc-collective#1187
- zinc-collective#2271
- zinc-collective#2253

One of the things we've kept bumping into is that each page has to
decide how wide it wants to be. That doesn't really seem sustainable or
particularly necessary; so now the Layout takes care of:

- Providing a Max-Width on every page
- Ensuring the Layout is centered horizontally
- Ensuring there is appropriate margin from the top
  of the screen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants