OTA fixes (and more) #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some entity names are a little messed up: 
|
TheJulianJES
reviewed
May 8, 2024
This reverts commit 2745306.
The `if self.is_transitioning` check at the top of the function "pins" the value during the execution context in mypy's eyes. There doesn't seem to be a way to force mypy to consider the property "`volatile`".
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #48 +/- ##
=======================================
Coverage 94.81% 94.81%
=======================================
Files 61 61
Lines 9191 9119 -72
=======================================
- Hits 8714 8646 -68
+ Misses 477 473 -4 ☔ View full report in Codecov by Sentry. |
dmulcahey
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tracks minor fixes I had to make to get things running.
Corresponding Core branch: dmulcahey/home-assistant@dm/zha-external-zha...puddly:core:puddly/zha-external-zha