Expose detection parameters for SNZB-03P #215
Draft
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This older(?) PIR occupancy device has some of the same parameters as the newer SNZB-06P. You can manually set them through the zigbee device management menu, but it would be nicer if there was a button in the main UI. The 03P model is a PIR sensor, but it still uses the ultrasonic tagged parameters to control the device. The PIR parameters all have a value of None.
|
I don't know how to test these changes. The recent splitting of zha from homeassistant-core has me confused. I own the device in question, but I'm not sure how to get these changes into my homeassistant instance which is running on a homeassisant green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #215 +/- ##
=======================================
Coverage 96.42% 96.42%
=======================================
Files 61 61
Lines 9390 9390
=======================================
Hits 9054 9054
Misses 336 336 ☔ View full report in Codecov by Sentry. |
dmulcahey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This older(?) PIR occupancy device has some of the same parameters as the newer SNZB-06P. You can manually set them through the zigbee device management menu, but it would be nicer if there was a button in the main UI. The 03P model is a PIR sensor, but it still uses the ultrasonic tagged parameters to control the device. The PIR parameters all have a value of None. These parameters are settable if you have the official Sonoff hub/app.