Implement smarter sensor polling #188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #188 +/- ##
=======================================
Coverage 95.89% 95.89%
=======================================
Files 61 61
Lines 9404 9412 +8
=======================================
+ Hits 9018 9026 +8
Misses 386 386 ☔ View full report in Codecov by Sentry. |
dmulcahey
changed the title
dmulcahey
commented
Sep 7, 2024
| @@ -394,34 +402,49 @@ def stop(self): | |||
| self._updater_task_handle = None | |||
| _LOGGER.debug("global updater stopped") | |||
|
|
|||
| def register_update_listener(self, listener: Callable): | |||
| def register_update_listener(self, listener: Callable | Callable[[], Awaitable]): | |||
There was a problem hiding this comment.
not sure if the typing is right on this...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way that polling sensors work.
PollableSensorhas been updated to use theGlobalUpdaterand a heuristic has been added to identify when the device is reporting attributes so that it can disable the polling since it shouldn't be needed.This accomplishes 3 things:
TODO: handle previously known device models so they avoid the work