Support new zigpy OTA update notification schema #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puddly
force-pushed
the
puddly/new-ota-format
branch
from
3f71054
to
f30a834
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #128 +/- ##
==========================================
+ Coverage 95.84% 95.89% +0.04%
==========================================
Files 61 61
Lines 9391 9404 +13
==========================================
+ Hits 9001 9018 +17
+ Misses 390 386 -4 ☔ View full report in Codecov by Sentry. |
…e is incompatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for passing more granular version metadata for OTA updates from zigpy, allowing us to show all current and past versions for an OTA update. This will allow (once Home Assistant supports it) downgrading firmwares from the UI, selecting images from multiple sources, and so on.
This changes OTA update entity semantics a little: the OTA entity is now "unknown" if we do not have an update for the device, as opposed to turning in "on".