Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoyalGardineer valve water consumed value converter #3558

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

mrrstux
Copy link
Contributor

@mrrstux mrrstux commented Nov 27, 2024

Proposed change

Converts RoyalGardineer valve water consumed value from deciliters to liters.

Additional information

Changes TuyaQuirkBuilder.tuya_meterig API to allow custom value scale.

Checklist

  • [ x] The changes are tested and work correctly
  • [x ] pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.79%. Comparing base (97413e3) to head (7ce801a).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3558   +/-   ##
=======================================
  Coverage   89.79%   89.79%           
=======================================
  Files         323      323           
  Lines       10414    10414           
=======================================
  Hits         9351     9351           
  Misses       1063     1063           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Nov 28, 2024
@mrrstux mrrstux force-pushed the royal-gardineer-valve-quirk-value-converter branch from 92a20f7 to 7ce801a Compare December 3, 2024 20:14
@mrrstux mrrstux marked this pull request as ready for review December 3, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants