Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure version-specific unit tests cover command sending format #639

Merged
merged 24 commits into from
Jul 24, 2024

Conversation

puddly
Copy link
Contributor

@puddly puddly commented Jul 24, 2024

In the future, we need to migrate bellows to a more robust framework that tests end-to-end command serialization and response parsing. Until then, I've replaced all blind mocks with those that also try to serialize the command.

There was a single error with EZSPv8 that has since been corrected.

Fixes #640

@puddly
Copy link
Contributor Author

puddly commented Jul 24, 2024

I've migrated test_application.py as well.

A future PR will add end-to-end testing of the entire command serialization format and adapter response for every EZSP version, hopefully like we do in zigpy-znp.

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.10%. Comparing base (61f7ec0) to head (55370ed).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #639      +/-   ##
==========================================
- Coverage   99.16%   99.10%   -0.06%     
==========================================
  Files          50       50              
  Lines        3460     3462       +2     
==========================================
  Hits         3431     3431              
- Misses         29       31       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@puddly puddly merged commit 595a285 into zigpy:dev Jul 24, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError: 'policyId' with bellows 0.40.0
1 participant