Consolidate all EZSP types #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix up v6
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #634 +/- ##
==========================================
- Coverage 99.38% 99.15% -0.24%
==========================================
Files 79 50 -29
Lines 5047 3412 -1635
==========================================
- Hits 5016 3383 -1633
+ Misses 31 29 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all copy/pasted EZSP types from EZSP v4 through v14. This greatly reduces the amount of code and strips down the individual EZSP protocol handlers to just the basics: command definitions and version-specific operations.
A future PR will migrate all command structures to proper types with named parameters.
bellows unit tests don't really cover version-level command serialization and deserialization so there's a chance that some types are incorrect. Runtime tested with EZSP v8 and v13.