Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmpctblock #144

Merged
merged 36 commits into from
Oct 3, 2024
Merged

Cmpctblock #144

merged 36 commits into from
Oct 3, 2024

Conversation

supreme2580
Copy link
Contributor

Closes: #99

src/network/protocol/messages/cmpctblock.zig Outdated Show resolved Hide resolved
src/network/protocol/messages/cmpctblock.zig Outdated Show resolved Hide resolved
src/network/protocol/messages/cmpctblock.zig Outdated Show resolved Hide resolved
src/network/protocol/messages/cmpctblock.zig Outdated Show resolved Hide resolved
@supreme2580
Copy link
Contributor Author

@tdelabro I have implemented the changes, it seems the zig server is down is why the test is failing

Copy link
Contributor

@TropicalDog17 TropicalDog17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to add the message to wire/lib.zig

@supreme2580
Copy link
Contributor Author

@TropicalDog17 done it

src/network/protocol/messages/cmpctblock.zig Outdated Show resolved Hide resolved
src/network/protocol/messages/cmpctblock.zig Outdated Show resolved Hide resolved
src/network/protocol/messages/cmpctblock.zig Outdated Show resolved Hide resolved
src/network/protocol/messages/cmpctblock.zig Show resolved Hide resolved
src/network/protocol/messages/lib.zig Outdated Show resolved Hide resolved
src/network/protocol/messages/lib.zig Outdated Show resolved Hide resolved
src/network/wire/lib.zig Outdated Show resolved Hide resolved
@supreme2580
Copy link
Contributor Author

@tdelabro I have implemented your suggestions

src/network/protocol/messages/cmpctblock.zig Outdated Show resolved Hide resolved
src/network/protocol/messages/cmpctblock.zig Outdated Show resolved Hide resolved
src/network/protocol/messages/cmpctblock.zig Outdated Show resolved Hide resolved
src/network/wire/lib.zig Outdated Show resolved Hide resolved
src/network/wire/lib.zig Outdated Show resolved Hide resolved
src/network/wire/lib.zig Outdated Show resolved Hide resolved
src/network/protocol/messages/cmpctblock.zig Outdated Show resolved Hide resolved
@tdelabro
Copy link
Collaborator

tdelabro commented Oct 3, 2024

@supreme2580 you forgot to use your eql method in tests

@supreme2580
Copy link
Contributor Author

@tdelabro isn't that try std.testing.expect(msg.eql(&deserialized)); ??

@supreme2580
Copy link
Contributor Author

@tdelabro I looked at the impl of getblocks it uses eql as try std.testing.expect(gb.eql(&deserialized_gb)); and I did the same, am I to do something different?

src/network/wire/lib.zig Outdated Show resolved Hide resolved
src/network/wire/lib.zig Outdated Show resolved Hide resolved
src/network/protocol/messages/cmpctblock.zig Outdated Show resolved Hide resolved
@tdelabro tdelabro merged commit 002228a into zig-bitcoin:main Oct 3, 2024
1 check passed
ybensacq pushed a commit to ybensacq/btczee that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmpctblock
3 participants