feat: merkleblock #125
Merged
feat: merkleblock #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bloomingpeach
force-pushed
the
feat/merkleblock
branch
from
d213814
to
6244a99
Compare
tdelabro
requested changes
Sep 26, 2024
|
@bloomingpeach I saw you pushed new commits but some of the previous review comments are still to be fixed, ping me when you are entirely done and ready to be reviewed again 👀 |
tdelabro
requested changes
Sep 27, 2024
|
Thanks for your review, I've refactored @tdelabro |
|
@tdelabro sorry I forgot to fix the other test, kindly review again. |
tdelabro
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #95