feat: add siphash24 implementation #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcoratger
reviewed
Sep 8, 2024
src/hashes/siphash24.zig
Outdated
Comment on lines
65
to
69
| if (T == u128) { | ||
| self.v2 ^= 0xee; | ||
| } else { | ||
| self.v2 ^= 0xff; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (T == u128) { | |
| self.v2 ^= 0xee; | |
| } else { | |
| self.v2 ^= 0xff; | |
| } | |
| self.v2 ^= if (T == u128) 0xee else 0xff; |
src/hashes/siphash24.zig
Outdated
|
|
||
| /// Initialize a state for a SipHash function | ||
| pub fn init(key: *const [key_length]u8) Self { | ||
| return Self{ |
There was a problem hiding this comment.
Suggested change
| return Self{ | |
| return .{ |
StringNick
reviewed
Sep 8, 2024
src/hashes/siphash24.zig
Outdated
| } | ||
|
|
||
| fn SipHash24(comptime T: type) type { | ||
| assert(T == u64 or T == u128); |
There was a problem hiding this comment.
i am not sure, maybe better compileError? wdyt @tcoratger @TropicalDog17
There was a problem hiding this comment.
yeah probably better here
StringNick
reviewed
Sep 8, 2024
src/hashes/siphash24.zig
Outdated
| pub const block_length = 8; | ||
| pub const c_rounds = 2; | ||
| pub const d_rounds = 4; | ||
| const State = SipHashStateless(T, c_rounds, d_rounds); |
There was a problem hiding this comment.
if we support u64 / u128 and SipHashStateless same (as in std), maybe we can use
const State = if (T == u64) SipHash64(c_rounds, d_rounds) else SipHash128(c_round, d_rounds);and we dont need copy full SipHashStateless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2
\cc @StringNick