Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow use shortcut keys without controller #249

Merged
merged 3 commits into from
Jan 29, 2022
Merged

feat: allow use shortcut keys without controller #249

merged 3 commits into from
Jan 29, 2022

Conversation

ambar
Copy link
Collaborator

@ambar ambar commented Jan 29, 2022

  • 新增：允许热键脱离 controller 使用（迁在 Player 内更合适，但它太长，拆到单独文件里了）—— 例子，在主站的所有视频，还没有播放时没有显示 controller，这时无法使用任意热键，同样播放结束时 controller 也隐藏了，还有不加载 controller 的平板也能外接键盘
  • 新增：将 Player 设置为可聚焦元素，这样即使 standalone=false 热键也能工作（对视频的任意操作都会聚焦到上面）—— standalone 看起来是个不恰当的属性，不正交，应当把它的行为拆开
  • 修复：ua 中加了 ua 和 typeof 判断：Safely read userAgent #18 fix: 对修复之前ie问题添加ie判断 #158

@ambar ambar merged commit 63f554a into zhihu:master Jan 29, 2022
@ambar ambar deleted the global-hotkey branch January 29, 2022 07:16
@ambar ambar mentioned this pull request Jan 29, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aftdotleo aftdotleo aftdotleo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ambar @aftdotleo